[backport camel-4.18.x] CAMEL-24622: camel-infinispan - keep completed exchanges for recovery - #26141
Merged
Merged
Conversation
…d exchanges for recovery
gnodet
commented
Sep 5, 2026
gnodet
left a comment
Contributor
Author
There was a problem hiding this comment.
Clean backport of CAMEL-24622. The fix correctly implements the RecoverableAggregationRepository contract — follows the same pattern as JdbcAggregationRepository (separate completed store keyed by exchange ID, as opposed to the broken previous behavior where scan() returned in-progress correlation keys and remove() deleted the exchange outright).
Key points verified:
remove()correctly moves the completed exchange from correlation-key storage into recovery storage (camel-recovery:<exchangeId>) instead of deleting itconfirm()correctly deletes from recovery storage using the prefixed keyscan()correctly filters to recovery entries only and strips the prefix to return exchange IDsgetKeys()correctly filters out recovery entries so the aggregation framework only sees in-progress aggregations- Tests are comprehensive: confirm lifecycle, scan semantics, recover lookup, and a new
testGetKeysIgnoresExchangesToRecovertest — both embedded and remote - Upgrade guide note correctly moved to
camel-4x-upgrade-guide-4_18.adocfor the backport
Metadata: No milestone set — suggest 4.18.5.
This review was generated by an AI agent, Hermès on behalf of @gnodet.
davsclaus
approved these changes
Sep 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #26115
Cherry-pick of d4539d7 to camel-4.18.x.
Conflicts resolved automatically by backport bot agent.
Conflict resolution
The upgrade guide note was moved from
camel-4x-upgrade-guide-4_23.adoc(does not exist on camel-4.18.x) tocamel-4x-upgrade-guide-4_18.adoc.