Conversation
Motivation: Scala 3.3.9-RC1 is available and it is useful to find out early whether Pekko builds and its tests pass on the upcoming 3.3.x LTS release. Modification: Bumped `scala3Version` in `project/Dependencies.scala` from 3.3.8 to 3.3.9-RC1. Result: CI builds and tests against Scala 3.3.9-RC1. This is a test build only and is not intended to be merged as-is. Tests: - Not run locally - relying on CI References: None - Scala 3.3.9-RC1 test build
Member
Author
|
I raised scala/scala3#27063 for the mima issues. The compilation and tests succeeded for Scala 3.3.9-RC1 |
Motivation: `sbt-pekko-build` sets `mimaReportSignatureProblems := true` for every Scala version. Scala 3 emits different generic signatures than Scala 2.13, which produces MiMa signature-problem noise on Scala 3 builds that does not reflect real binary incompatibilities. Modification: Override `mimaReportSignatureProblems` in `PekkoBuild.defaultSettings` so it is `false` when `scalaVersion` is 3.x and `true` otherwise. Added the key to `Global / excludeLintKeys` since it is unused in modules that disable `MimaPlugin`. Result: MiMa still reports signature problems for Scala 2.13 but not for Scala 3. Tests: - Ran native `scalafmt` on the changed files. - MiMa not run locally - relying on CI. References: None
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Scala 3.3.9-RC1 is available and it is useful to find out early whether Pekko builds and its tests pass on the upcoming 3.3.x LTS release.
Modification
Bumped
scala3Versioninproject/Dependencies.scalafrom 3.3.8 to 3.3.9-RC1.Result
CI builds and tests against Scala 3.3.9-RC1. This is a test build only and is not intended to be merged as-is.
Tests
References
None - Scala 3.3.9-RC1 test build