Skip to content

Dynamic Fields With Defer #95

Description

@ahshah

Hi folks,
I'd like to add a field to my logging context after I have some relevant information, I've supplied the peudocode of what I'd like to do. Looking over the code in log/entry.go, this should be pretty straightforward, however it seems like a conscience decision to not allow modification to the Entry structs field variable. Instead, similar functions (i.e WithField) require the building of a new Entry entirely.
Why is the Entry struct immutable in this way?

func DownloadFile() (int) { 
   // Off to the network we go
}
func main() {
      ctx := log.WithFields(log.Fields{
          "module": "main",
     })
     defer ctx.Info("Download complete")
     bytesDownloaded := DownloadFile()
     ctx.AddField("downloadSize", bytesDownloaded)
}

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions