Repository navigation
HTTPClientCapability.TLSHandler: Server trust and client certificate callbacks - #192
Open
guoye-zhang wants to merge 2 commits into
Open
guoye-zhang wants to merge 2 commits into
guoye-zhang wants to merge 2 commits into
Conversation
FranzBusch
reviewed
Oct 5, 2026
| /// configuration. | ||
| func handleClientCertificateChallenge(distinguishedNames: [Data]) async throws -> (SecIdentity, [SecCertificate])? | ||
| func handleClientCertificateChallenge( | ||
| distinguishedNames: [DistinguishedName] |
Member
There was a problem hiding this comment.
For the future we should think if we should use Span<DistinguishedName> name here potentially might need new swift-certificates APIs though
|
|
||
| /// An error raised while applying ``HTTPClientCapability/TLSHandler`` options to a request. | ||
| @available(anyAppleOS 26.0, *) | ||
| public struct HTTPClientTLSError: Error, Hashable, Sendable, CustomStringConvertible { |
Member
There was a problem hiding this comment.
Why does this error type exist here? I am not sure we should define a common error type here for TLS cert errors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using swift-certificates for Certificate and PrivateKey types. Implemented in both URLSession and AHC.
Dependencies:
swift-certificates PR: apple/swift-certificates#321
AHC branch: https://github.com/guoye-zhang/async-http-client/tree/per-request-tls-verification