Add cfgs to distinguish WASIp3 and WASIp2 targets - #142
Merged
Conversation
Contributor
Author
|
Still investigating the test failure, but I was able to reproduce it on |
Contributor
Author
|
Fix for the test here: #143 |
pchickey
approved these changes
Sep 2, 2026
adamrk
force-pushed
the
abk/p3-feature-base
branch
from
September 3, 2026 14:24
170b21b to
ea32edf
Compare
adamrk
commented
Sep 3, 2026
adamrk
commented
Sep 9, 2026
Comment on lines
-32
to
+34
| rustup default "${{ steps.select.outputs.version }}" | ||
| # `rustup default` gets overwritten by rust-toolchain.toml, `rustup | ||
| # override` has higher precedence though. | ||
| rustup override set "${{ steps.select.outputs.version }}" |
Contributor
Author
There was a problem hiding this comment.
Note: it looks like our previous setup was actually running the stable toolchain for the msrv and nightly jobs because the included rust-toolchain.toml file was overriding the default set here.
adamrk
commented
Sep 9, 2026
Comment on lines
-62
to
+67
| rust-version = "1.91.1" | ||
| rust-version = "1.92.0" |
Contributor
Author
There was a problem hiding this comment.
Had to bump the msrv because 1.91.1 doesn't have the p3 target_env and using it will throw a warning.
adamrk
changed the title
cfgs to distinguish WASIp3 and WASIp2 targets
pchickey
approved these changes
Sep 9, 2026
pchickey
left a comment
pchickey
left a comment
Contributor
There was a problem hiding this comment.
Thanks, just a couple minor tweaks
Contributor
Author
|
Thanks, I fixed all that stuff left over from the feature. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gate WASIp2 specific features behind
cfg(all(target_os = "was", target_env = "p2"))to set up WASIp3 implementation.Addresses #144