Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nova servers in
BUILDorDELETINGare currently reported aspending_createorpending_delete, which GARM rejects in provider results. A single such server can fail validation of the entireListInstancesresponse and prevent pool or scale-set reconciliation. Other unmapped Nova states currently produce an empty status, which GARM also rejects.Use typed constants for the existing
ACTIVE,SHUTOFF, andERRORmappings, and returnInstanceStatusUnknownfor all other states. Add table-driven conversion coverage and extend the existing HTTP list test with building and deleting servers alongside a running server.Validation: the regression tests fail before the fix and pass afterward; the full vendored test suite passes with the race detector, as do repository lint, formatting, and dependency consistency checks.