Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A single HTTP 429 during server creation, deletion, or status polling currently fails the operation. The one-second status polling interval also adds substantial API load when multiple runners are provisioning.
Configure each service client's Gophercloud retry hook for up to 10 retries on rate-limit responses (429 and Gophercloud's existing 498 handling). Honor Retry-After seconds or HTTP dates; otherwise use exponential backoff from 2 seconds with jitter, capped at 60 seconds. Backoff respects context cancellation. Poll server status every five seconds after the previous check completes, retaining the existing operation deadlines.
Tests cover client configuration, create/delete recovery, the 11-request limit, non-rate-limit errors, Retry-After parsing and overflow, cancellation, and polling cadence. Timer tests use Go's virtual clock without changing production intervals. Full vendored tests with the race detector, repository lint, formatting, and dependency consistency checks pass.
The retry policy applies after service-client initialization. Initial authentication, endpoint discovery during construction, and Keystone reauthentication are outside this change; the existing constructor authenticates before exposing the ProviderClient.