Skip to content

Read config from ~/.rid - #15

Open
awakia wants to merge 4 commits into
creasty:masterfrom
wantedly:awakia/global_rid
Open

awakia wants to merge 4 commits into
creasty:masterfrom
wantedly:awakia/global_rid

Conversation

@awakia

@awakia awakia commented Oct 12, 2017

Copy link
Copy Markdown

Why

we want to use command like rid pg or rid es anywhere without adding rid-pg / rid-es to every ripository

What

to solve that problem, this PR

  • enables to read substitution command from ~/.rid/libexec
  • enables to run such rid command (which runs outside of container) without configfile

the problem here is it is hard to write test.
@creasty please take a look?

@codecov

codecov Bot commented Oct 12, 2017

Copy link
Copy Markdown

Codecov Report

Merging #15 into master will decrease coverage by 2.63%.
The diff coverage is 26.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #15      +/-   ##
==========================================
- Coverage   57.21%   54.58%   -2.64%     
==========================================
  Files           4        4              
  Lines         194      240      +46     
==========================================
+ Hits          111      131      +20     
- Misses         74       98      +24     
- Partials        9       11       +2
Impacted Files Coverage Δ
cli/cli.go 52.21% <0%> (-2.89%) ⬇️
project/context.go 56.16% <36.36%> (-1.53%) ⬇️
util/util.go 53.33% <0%> (-5.93%) ⬇️
project/config.go 62.5% <0%> (-2.21%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1f29e9...062ea52. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant