COBS-1290: Add Insights alert rules OpenAPI - #1225
Open
dmamidala-glitch wants to merge 9 commits into
Open
dmamidala-glitch wants to merge 9 commits into
dmamidala-glitch wants to merge 9 commits into
Conversation
Document public CRUD for /v2/insights/alert-rules against the api-service contract and Edge scopes from COBS-1287. Co-authored-by: Cursor <cursoragent@cursor.com>
Match staging: protobuf omitempty drops total when zero. Co-authored-by: Cursor <cursoragent@cursor.com>
Use lowercase enums, duration strings, links/meta list envelope, and dotted OTel metric guidance from the Alerts Public Insights API RFC. Co-authored-by: Cursor <cursoragent@cursor.com>
2 of 4 tasks
dmamidala-glitch
marked this pull request as ready for review
September 16, 2026 11:57
2 of 6 tasks
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
atalluri-do
reviewed
Sep 30, 2026
| - `EVALUATION_WINDOW_30M` = `30m` | ||
| - `EVALUATION_WINDOW_1H` = `1h` | ||
| enum: | ||
| - EVALUATION_WINDOW_UNSPECIFIED |
Contributor
There was a problem hiding this comment.
Could you double if "EVALUATION_WINDOW_UNSPECIFIED" is a valid window?
| description: | | ||
| Current alert rule status. Values use the API's protobuf enum names. | ||
|
|
||
| - `ALERT_RULE_STATUS_UNSPECIFIED` = unspecified |
Contributor
There was a problem hiding this comment.
same with this as well.
| description: | | ||
| Desired alert rule status. Values use the API's protobuf enum names. | ||
|
|
||
| - `ALERT_RULE_STATUS_UNSPECIFIED` = unspecified |
| Comparison operator applied to the aggregated metric value. Values use | ||
| the API's protobuf enum names. | ||
|
|
||
| - `THRESHOLD_OPERATOR_UNSPECIFIED` = unspecified |
| operator: | ||
| type: string | ||
| description: | | ||
| Comparison operator applied to the aggregated metric value. Values use |
Contributor
There was a problem hiding this comment.
Also, can you remove reference to protobuf. Internal details are not needed public API documentation.
Co-authored-by: Cursor <cursoragent@cursor.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/v2/insights/alert-rules.links/metalist envelope,page/per_page(default 20, max 200), and scopesinsights:read|create|update|delete.422for underscored Prometheus-style metric names.Test plan
make lintpasses (0 Spectral errors)Blocked by / ships after: COBS-1287 Edge routing.
Related: notification-channels draft #1224 (COBS-1289).