Skip to content

build(deps): bump eic-spack to 9dff4f5 - #451

Open
wdconinc wants to merge 1 commit into
masterfrom
automation/update-eic-spack
Open

wdconinc wants to merge 1 commit into
masterfrom
automation/update-eic-spack

Conversation

@wdconinc

@wdconinc wdconinc commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

Bumps eic/eic-spack from 92390fc to 9dff4f5 (head of develop).

Commits (3)

Full comparison: eic/eic-spack@92390fc...9dff4f5


This pull request is maintained automatically by .github/workflows/update-eic-spack.yml.
It is rebuilt from master every night, so manual pushes to its branch will be overwritten.

Copilot AI balanced review requested due to automatic review settings October 6, 2026 10:30

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🔵 Needs a closer look

The edit itself is a correct, mechanical SHA bump, but it changes which upstream package definitions the images build against, whose effects can only be validated by the dual CI build pipelines and warrant human confirmation.

Review effort: Balanced
Findings: None

What changed in this PR

This is an automated dependency bump that updates the pinned eic/eic-spack repository revision used when building the EIC container images. The EICSPACK_VERSION value in eic-spack.sh is resolved to a SHA and passed as a build arg into the Debian base image, which checks out that revision of the eic-spack package repository, so this hash effectively controls which eic-spack package definitions the images are built against.

Changes:

  • Bumps EICSPACK_VERSION from 92390fc... to 9dff4f5... (head of eic-spack develop), pulling in three upstream commits (two CI dependency bumps and an elfutils patch constraint).
File Description
eic-spack.sh Updates the pinned eic-spack commit SHA to 9dff4f535515734332366168ecc2db5547a16d7e.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@github-actions

github-actions Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

Capybara summary for PR 451

@wdconinc
wdconinc enabled auto-merge (squash) October 6, 2026 12:11
Copilot AI balanced review requested due to automatic review settings October 7, 2026 10:24
@wdconinc
wdconinc force-pushed the automation/update-eic-spack branch from 3dce1c8 to fda91b6 Compare October 7, 2026 10:24

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🔵 Needs a closer look

The bump moves the eic-spack package-repository revision to a new develop head that feeds image concretization/builds, so safety depends on both GitHub Actions and GitLab CI passing, which cannot be verified here.

Review effort: Balanced
Findings: None

@wdconinc
wdconinc force-pushed the automation/update-eic-spack branch from fda91b6 to 62d1ab8 Compare October 8, 2026 10:44
Copilot AI balanced review requested due to automatic review settings October 8, 2026 10:44

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The one-line change is correct and well-formed, but advancing the eic-spack repository pin affects downstream package concretization and builds across all environments/architectures, whose safety can only be confirmed by the dual (GitHub Actions and GitLab/EICweb) CI runs.

0 open findings

🧠 Review effort: Balanced


Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.

Bumps eic/eic-spack from 92390fcef76214c0e315a0d5f894ddd07ff5de6d to 9dff4f535515734332366168ecc2db5547a16d7e.
Copilot AI balanced review requested due to automatic review settings October 9, 2026 10:43
@wdconinc
wdconinc force-pushed the automation/update-eic-spack branch from 62d1ab8 to 4640775 Compare October 9, 2026 10:43

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Although the hash is valid and correctly matches the PR description, bumping the eic-spack pin changes the upstream package source and must be validated by both GitHub Actions and GitLab CI builds before approval.

0 open findings

🧠 Review effort: Balanced

This branch was successfully deployed

1 active deployment
github-pages — 46407750 Deployed Oct 9, 2026 by wdconinc via deploy-artifacts-page #4291
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants