build_library: use smaller rootfs for Akamai - #4270
Conversation
This was working fine until Linode enforced the size limit (i.e 6Gb uncompressed image). rootfs should expand to the available disk size anyway. Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
There was a problem hiding this comment.
🟢 Approval recommended
The change is minimal, consistent with existing layout fallback behavior, and directly aligns with the stated goal of reducing initial image size.
Pull request overview
Adjusts the Akamai (Linode) VM image build settings to reduce the initial root filesystem size, addressing Linode’s enforced uncompressed image size limit while still relying on runtime expansion.
Changes:
- Stop selecting the
vmdisk layout for Akamai images so the defaultbaselayout is used (smaller initial ROOT partition).
File summaries
| File | Description |
|---|---|
| build_library/vm_image_util.sh | Removes the Akamai-specific DISK_LAYOUT=vm override so Akamai images fall back to the smaller default disk layout. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
There was a problem hiding this comment.
🟡 Changes recommended
The Akamai image conversion has a critical layout incompatibility that must be resolved before approval.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review details
Suppressed comments (1)
build_library/vm_image_util.sh:233
- The PR description still leaves the changelog requirement unchecked, but this is a user-facing Linode/Akamai image-size bug fix. Please add a concise entry under
changelog/bugfixes/before merging so the fix is included in release notes.
IMG_akamai_DISK_LAYOUT=akamai
- Files reviewed: 2/2 changed files
- Comments generated: 2
- Review effort level: Lite
| "9":{ | ||
| "label":"ROOT", | ||
| "fs_label":"ROOT", | ||
| "blocks":"131072" |
|
|
||
| ## akamai (Linode) | ||
| IMG_akamai_DISK_LAYOUT=vm | ||
| IMG_akamai_DISK_LAYOUT=akamai |
43e715f to
59bd939
Compare
There was a problem hiding this comment.
🔵 Needs a closer look
Add the required changelog entry before merging.
Review details
Suppressed comments (1)
build_library/vm_image_util.sh:233
- This changes the published Akamai/Linode image layout and fixes a user-facing image-size regression, so it needs a changelog entry. The repository requires bug-fix/change entries under
changelog/for this kind of change (changelog/README.md:1-13), but the PR currently adds none; please add one before merging.
IMG_akamai_OEM_SYSEXT=akamai
- Files reviewed: 1/1 changed files
- Comments generated: 0 new
- Review effort level: Lite
|
Cherry-picked to:
|
This was working fine until Linode enforced the size limit (i.e 6Gb uncompressed image).
rootfs should expand to the available disk size anyway.
This partially reverts: f0c94a9
This creates a raw disk of
7.88Gib:It's not ideal, but we can't lower more.
changelog/directory (user-facing change, bug fix, security fix, update)/bootand/usrsize, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc.