Skip to content

Fix build under GCC 14 and add GCC 14 deploy test #1686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
elliottslaughter wants to merge 4 commits into from
Closed

Fix build under GCC 14 and add GCC 14 deploy test #1686

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0f2dd1c
Fixes for GCC 14 and deploy test.
elliottslaughter Sep 16, 2026
14751b8
Fixes for op-attrs.
elliottslaughter Sep 16, 2026
8f6e66d
Remove fmt/optional from graph DTG.
elliottslaughter Sep 18, 2026
0530410
Remove template hacks.
elliottslaughter Sep 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/deploy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,4 +23,4 @@ jobs:

strategy:
matrix:
gcc: [10, 11]
gcc: [10, 11, 14]
3 changes: 2 additions & 1 deletion lib/op-attrs/include/op-attrs/parallel_dim.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
#define _FLEXFLOW_OP_ATTRS_INCLUDE_OP_ATTRS_PARALLEL_DIM_H

#include "op-attrs/parallel_dim.dtg.h"
#include "utils/positive_int/positive_int.h"

namespace FlexFlow {

Expand All @@ -11,7 +12,7 @@ bool is_replica_dim(ParallelDim const &);
ParallelDim with_size_set_to(ParallelDim const &, size_t);
ParallelDim with_degree_set_to(ParallelDim const &, int);
ParallelDim with_is_replica_set_to(ParallelDim const &, bool);
int get_degree(ParallelDim const &);
positive_int get_degree(ParallelDim const &);

} // namespace FlexFlow

Expand Down
4 changes: 2 additions & 2 deletions lib/op-attrs/src/op-attrs/parallel_dim.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@

namespace FlexFlow {

int get_degree(ParallelDim const &dim) {
return dim.visit<int>(overload{
positive_int get_degree(ParallelDim const &dim) {
return dim.visit<positive_int>(overload{
[](ShardParallelDim const &shard_dim) { return shard_dim.degree; },
[](ReplicaParallelDim const &replica_dim) {
return replica_dim.degree;
Expand Down
1 change: 1 addition & 0 deletions lib/utils/include/utils/containers/filter.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
#include <algorithm>
#include <map>
#include <set>
#include <unordered_map>
#include <unordered_set>
#include <vector>

Expand Down
3 changes: 3 additions & 0 deletions lib/utils/include/utils/containers/inplace_filter.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,9 @@

#include "utils/containers/filter.h"
#include <algorithm>
#include <map>
#include <set>
#include <unordered_map>
#include <unordered_set>
#include <vector>

Expand Down
2 changes: 1 addition & 1 deletion lib/utils/include/utils/containers/unordered_set_of.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ namespace FlexFlow {

template <typename C, typename T = typename C::value_type>
std::unordered_set<T> unordered_set_of(C const &c) {
return std::unordered_set{c.cbegin(), c.cend()};
return std::unordered_set<T>{c.cbegin(), c.cend()};
}

template <typename K, typename V>
Expand Down
Loading