Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
checkjob is the repo's only required status check, and itsneedslist omits thelintjob.HLint therefore runs on every PR, reports its result, and cannot block a merge — a warning-level
failure is advisory today.
Adding
linttoneedscloses that without changing the ruleset:checkis already the requiredcontext, so nothing in
github-vending-machineneeds to move.This is the shape
haskell-library-templateships, and the shape freckle/github-vending-machine#263moved that template's ruleset to. 37 of 43 haskell-package repos have the same gap, either missing the
aggregator entirely or declaring
needs: [test]like this one; the three that already require onlycheckare the cases fixable in one line.The test failures on this PR are pre-existing, not caused by this change
This diff adds one entry to a
needslist and cannot affect a Stack build. The cause is a cold cache:This repo's last full CI run was 2026-08-20. Everything on
mainsince then has been the scheduledMergeabot workflow, which does not build. GitHub evicts Actions caches after 7 days of non-use, so this
PR is the first cold rebuild in three weeks, and it failed while populating the package index rather
than on anything in the code.
Re-running the failed jobs cleared it: all 19 checks now pass. So the failure was transient
infrastructure, not a defect in this repo, and nothing needs fixing before lint is gated here.
HLint itself passes (
lintis green on this PR), and it is set tofail-on: warning, so merging thisdoes make existing HLint warnings merge-blocking.