Repository navigation
Align scripts, Node pin and docs with the templates - #251
Conversation
✅ Deploy Preview for fulldev-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (7)
💤 Files with no reviewable changes (1)
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 1 remain after this review. 📝 WalkthroughWalkthroughThe release workflow now reads the Node.js version from Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Other Merge Risk: ⚪ Minimal · up to The updated tooling and deployment configuration is ready to merge after normal checks. Security Architecture ReviewSecurity architecture risk: 🔵 Low · up to The release credentials and npm publication safeguards are unchanged, and site builds now include HTML validation. However, production and preview configuration parity, secret exposure, and rollback behavior cannot be confirmed from the repository alone. Retained concerns Security review detailsSecurity Blast Radius
Trust Boundaries and Controls
Resilience and Maintainability Implications
Hardening Proposals
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
check no longer builds the site; build validates the HTML, as in astro-template, so the Netlify deploy preview runs it for every PR. fix formats and applies lint fixes, and the duplicate format scripts are gone. .nvmrc becomes .node-version, CLAUDE.md loads AGENTS.md, and CONTRIBUTING matches the current Node, pnpm and npm release. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
The same command and publish directory the fulldev-ui site had in the Netlify UI, so the repository holds them like every other Fulldev site. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
6c0b6bf to
001c358
Compare
Follow-up to the template alignment, from a council review. No changeset: nothing changes for people who install components or the package.
package.json:check= prettier, types, ESLint andregistry:check. It no longer runspnpm build.build=astro build && html-validate dist, as in astro-template. The fulldev-ui site builds a deploy preview for every PR withpnpm run build, so HTML validation still runs per PR.fixadded.format,format:write,format:checkandlintremoved (duplicates, or inlined incheck);typecheckstays..nvmrcrenamed to.node-version(still 24);release.ymlreads it.engineskeeps>=22.12.0for consumers, and so does the README's install section.CLAUDE.mdwith@AGENTS.md, as in the other repositories, so Claude loads the project instructions.CONTRIBUTING.md: Node 24 and pnpm 12 for contributors, the new script descriptions, and releases do publishfulldev-uito npm.AGENTS.md: release prep ispnpm checkandpnpm build.Left out on purpose:
.agents/skills/fulldev/cli.mdand the README install steps, which #247 rewrites, andnetlify.toml, whose build settings live in the Netlify UI (a production change for ui.full.dev, left to you).Checked:
pnpm checkandpnpm build. Not for an agent to merge (a merge can publish a release).🤖 Generated with Claude Code
Summary by CodeRabbit
fulldev-uinpm package.