Skip to content

Align scripts, Node pin and docs with the templates - #251

Merged
silveltman merged 2 commits into
mainfrom
fix/align-council
Oct 3, 2026
Merged

silveltman merged 2 commits into
mainfrom
fix/align-council

Conversation

@silveltman

@silveltman silveltman commented Oct 3, 2026 •

Copy link
Copy Markdown
Collaborator

Follow-up to the template alignment, from a council review. No changeset: nothing changes for people who install components or the package.

  • package.json:
    • check = prettier, types, ESLint and registry:check. It no longer runs pnpm build.
    • build = astro build && html-validate dist, as in astro-template. The fulldev-ui site builds a deploy preview for every PR with pnpm run build, so HTML validation still runs per PR.
    • fix added. format, format:write, format:check and lint removed (duplicates, or inlined in check); typecheck stays.
  • .nvmrc renamed to .node-version (still 24); release.yml reads it. engines keeps >=22.12.0 for consumers, and so does the README's install section.
  • CLAUDE.md with @AGENTS.md, as in the other repositories, so Claude loads the project instructions.
  • CONTRIBUTING.md: Node 24 and pnpm 12 for contributors, the new script descriptions, and releases do publish fulldev-ui to npm. AGENTS.md: release prep is pnpm check and pnpm build.

Left out on purpose: .agents/skills/fulldev/cli.md and the README install steps, which #247 rewrites, and netlify.toml, whose build settings live in the Netlify UI (a production change for ui.full.dev, left to you).

Checked: pnpm check and pnpm build. Not for an agent to merge (a merge can publish a release).

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Release
    • Releases publish the component registry and the fulldev-ui npm package.
  • Documentation
    • Updated contribution guidance with the current Node.js and pnpm requirements, validation commands, and release details.
  • Maintenance
    • Updated release and hosting configuration to use the project’s configured Node.js version.
    • Validation commands now separate code checks from the site build and HTML validation.

@netlify

netlify Bot commented Oct 3, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for fulldev-ui ready!

Name Link
🔨 Latest commit 001c358
🔍 Latest deploy log https://app.netlify.com/projects/fulldev-ui/deploys/6ac0e3716659fa0009cae061
😎 Deploy Preview https://deploy-preview-251--fulldev-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@coderabbitai

coderabbitai Bot commented Oct 3, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: ec496f51-7819-473c-967b-6ed922d22766
📥 Commits

Reviewing files that changed from the base of the PR and between 6c0b6bf and 001c358.

📒 Files selected for processing (7)
  • .github/workflows/release.yml
  • .node-version
  • AGENTS.md
  • CLAUDE.md
  • CONTRIBUTING.md
  • netlify.toml
  • package.json
💤 Files with no reviewable changes (1)
  • .node-version

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 1 remain after this review.


📝 Walkthrough

Walkthrough

The release workflow now reads the Node.js version from .node-version. Netlify settings specify the build command and publish directory. Package scripts update the check, fix, build, and registry formatting commands. Contribution and project guidance describe the toolchain requirements, command roles, and release publishing details.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to 001c3

The updated tooling and deployment configuration is ready to merge after normal checks.

Security Architecture Review

Security architecture risk: 🔵 Low · up to 001c3

The release credentials and npm publication safeguards are unchanged, and site builds now include HTML validation. However, production and preview configuration parity, secret exposure, and rollback behavior cannot be confirmed from the repository alone.

Retained concerns
No architecture-level concerns identified.

Security review details

Security Blast Radius

  • inferred — The directly affected authority surface is the site's repository-declared build configuration and its generated publish directory. The scoped changes do not add tenant controls, IAM policies, secret bindings, or network rules; external deployment credentials and environment scopes remain unverified.

Trust Boundaries and Controls

  • observed — Registry publication still invokes registry:check before changeset publish in both base and head. The release workflow calls that script rather than bypassing it. Importing project guidance through CLAUDE.md adds no executable permission or credential configuration.

Resilience and Maintainability Implications

  • observed — Same-workflow, same-ref release runs remain serialized without cancelling an in-progress run. This unchanged control limits overlapping release execution, but does not prove publication idempotency or recovery after interruption.

Hardening Proposals

  • proposed — Confirm effective production and preview commands, publish directories, build-secret scopes, failed-build publication behavior, and rollback fallback before relying on parity with the previous UI-managed configuration.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main changes to scripts, Node version configuration, and documentation.
Description check ✅ Passed The description explains the script, Node version, and documentation changes and is directly related to the pull request.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

silveltman and others added 2 commits October 3, 2026 13:10
check no longer builds the site; build validates the HTML, as in
astro-template, so the Netlify deploy preview runs it for every PR. fix formats
and applies lint fixes, and the duplicate format scripts are gone. .nvmrc
becomes .node-version, CLAUDE.md loads AGENTS.md, and CONTRIBUTING matches the
current Node, pnpm and npm release.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
The same command and publish directory the fulldev-ui site had in the Netlify
UI, so the repository holds them like every other Fulldev site.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@silveltman
silveltman merged commit d27344e into main Oct 3, 2026
7 checks passed
@silveltman
silveltman deleted the fix/align-council branch October 3, 2026 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant