Repository navigation
ci: Bump Craft action to 2.33.3 - #5699
Merged
Merged
Conversation
The Craft action resolves its binary version from the action ref. With a SHA pin, Craft < 2.33.2 can't map the SHA to a release and silently falls back to the latest release. Set craft_version explicitly so the pin holds. Co-Authored-By: Ricardo Oliveira <ricardo.oliveira@sentry.io>
Craft >= 2.33.2 resolves a SHA action ref to its matching published release, so the action pin alone now selects the Craft binary and stays in sync with Dependabot bumps. Co-Authored-By: Ricardo Oliveira <ricardo.oliveira@sentry.io>
sentry-junior
Bot
changed the title
ric-oliv
marked this pull request as ready for review
October 8, 2026 09:35
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit f78cb8e. Configure here.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5699 +/- ##
==========================================
- Coverage 75.13% 75.12% -0.01%
==========================================
Files 515 515
Lines 18989 18989
Branches 3693 3693
==========================================
- Hits 14267 14266 -1
- Misses 3867 3868 +1
Partials 855 855 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
giortzisg
approved these changes
Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The release workflow pins
getsentry/craftby commit SHA. Before 2.33.2, the Craft action usedgithub.action_ref(the SHA) as the binary release tag. No release exists for a SHA, so the action quietly fell back to the latest Craft binary. The pin fixed the action code but not the Craft binary.The last release run (36816925951, 2026-10-01) shows this:
Craft 2.33.2 changed this (getsentry/craft#891): a SHA action ref now resolves to its matching published release, and the step fails if there isn't one. This PR bumps the pin to
4e16427(2.33.3, latest), so the action pin alone picks both the action code and the Craft binary. That also keeps both in sync on future Dependabot bumps.The disabled changelog-preview workflow gets the same bump so the two pins don't drift apart.
Behaviour change: the next release runs Craft 2.33.3 instead of the 2.31.2 that the last release ran. The
version,forceandmerge_targetinputs are unchanged in 2.33.3.#skip-changelog
via Ricardo Oliveira.
--
View Junior Session [Sentry]