Skip to content

Accelerate the check-for-missing-dlls CI runs in git-sdk-arm64 - #750

Merged
dscho merged 1 commit into
mainfrom
investigate-pe-imports.ps1-slowness
Sep 29, 2026
Merged

dscho merged 1 commit into
mainfrom
investigate-pe-imports.ps1-slowness

Conversation

@dscho

@dscho dscho commented Sep 26, 2026 •

Copy link
Copy Markdown
Member

The ARM64 variant of the check-for-missing-dlls workflow takes vastly longer than the x64 one; In one concrete comparison, the ten Windows PowerShell 5.1 invocations took about 437 seconds, while 88 objdump batches took about 11 seconds (which is on par with the x64 which does not need to fall back to the pe-imports.ps1 script). (example run)

The Actions Runner images already includes native ARM64 PowerShell 7.Using this executable instead, the cumulative time to runpe-imports.ps1 ten times went down to 6.1s. So let's use pwsh instead.

The ARM64 variant of the `check-for-missing-dlls` workflow takes vastly
longer than the x64 one; In one concrete comparison, the ten Windows
PowerShell 5.1 invocations took about 437 seconds, while 88 `objdump`
batches took about 11 seconds (which is on par with the x64 which does
_not_ need to fall back to the `pe-imports.ps1` script). See
https://github.com/git-for-windows/build-extra/actions/runs/36238304822

The Actions Runner images already includes native ARM64 PowerShell 7.
Using this executable instead, the cumulative time to run
`pe-imports.ps1` ten times went down to 6.1s. So let's use `pwsh`
instead.

Assisted-by: GPT-6 Sol
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
@dscho
dscho force-pushed the investigate-pe-imports.ps1-slowness branch from 898f434 to 38189f7 Compare September 26, 2026 20:01
@dscho dscho changed the title Measure ARM64 DLL-check timing with PowerShell 7 Accelerate the check-for-missing-dlls CI runs in git-sdk-arm64 Sep 26, 2026
@dscho dscho self-assigned this Sep 26, 2026
@dscho
dscho requested review from mjcheetham and rimrul September 26, 2026 20:03
@dscho
dscho marked this pull request as ready for review September 26, 2026 20:03

@mjcheetham mjcheetham left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice perf win!

@dscho
dscho merged commit 2a3ceed into main Sep 29, 2026
9 checks passed
@dscho
dscho deleted the investigate-pe-imports.ps1-slowness branch September 29, 2026 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants