Update runner-doctor catalog with B29, B30, and C10 - #8070
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
The portable catalog accidentally replaces C9 with C10, leaving its C9 references unresolved.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Updates runner-doctor knowledge for three recently fixed AWF failure modes.
Changes:
- Adds B29, B30, and C10 diagnostics and remediation.
- Synchronizes workflow and portable-agent guidance.
- Updates alignment tests and generated metadata.
File summaries
| File | Description |
|---|---|
scripts/ci/self-hosted-runner-doctor-workflow.test.ts |
Tests new catalog entries. |
.github/workflows/shared/self-hosted-failure-modes.md |
Adds canonical failure-mode records. |
.github/workflows/self-hosted-runner-doctor.md |
Adds diagnostic mappings and playbook guidance. |
.github/workflows/self-hosted-runner-doctor.lock.yml |
Updates generated body hash. |
.github/agents/self-hosted-runner-doctor.md |
Updates portable catalog and playbook. |
Review details
- Files reviewed: 5/5 changed files
- Comments generated: 1
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
@copilot address review feedback and rebase main |
…-doctor-lessons Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>
Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>
Restored the C9 row in the portable runner-doctor catalog and added an alignment assertion in commit |
|
✅ Copilot review passed with no inline comments. @copilot Add the |
Adds three newly identified self-hosted/GHEC failure-mode lessons to the shared catalog, workflow playbook, and portable runner-doctor agent:
awf logs summaryto report no sources.Authorizationschemes, GHEC model-discovery gaps, and legacy placeholder credential handling.Each entry includes remediation, probes, citations, and the corresponding quick-lookup signal. The workflow alignment tests and generated lock metadata are updated to keep all catalog copies synchronized.
Example diagnostic mappings: