Add operational-value grader for architecture-guardian workflow

[Copilot]

architecture-guardian had no deterministic operational-value grader. This adds one designed per .github/skills/operational-value-designer/SKILL.md, as a fresh research run independent of any existing workflow's contract.

Research

• Recovered adoption-time intent from the workflow's actual first commit (559b2b3, 2026-04-08), which defines four independent structural checks: file size, function size, export count, and import cycles.
• Checked real pre-existing remediation evidence across 5 "Architecture Violations Detected" issues: only Architecture Violations Detected — 2026-04-23 #28113 was closed by an actually-merged fix (PR Refactor MCP setup generation to eliminate generateMCPSetup architecture violation #28114, decomposing an 852-line generateMCPSetup); Architecture Violations Detected — 2026-04-13 #26048 and Architecture Violations Detected — 2026-04-14 #26230 closed without a merged fix. This shows issue-closure status alone is not a trustworthy remediation signal.

Contract design

• Tracks decomposition of the run's longest oversized non-test Go function (not file size — that's already daily-file-diet's metric) toward half of the effective function_lines threshold read from .architecture.yml, using the same ^func-marker scan method the workflow's own pre-step already uses.
• Accepted evidence is git-only (re-scanning the assigned function's span at the evidence cutoff); issue/PR status is explicitly excluded given the finding above.
• Maturation window is 7 days — deliberately longer than the workflow's 2-day issue auto-expiry, since confirmed fixes can land after the issue itself has expired.
• Baseline mode is attainment-only: no comparable pre-adoption process existed to score retroactively.
• Two separate diagnostics (longest-function-health, compliant-function-line-share) provide repository-wide context without contributing to the primary value.

Files

• .github/graders/architecture-guardian-operational-value.sh — new evaluator (--definition / --metric / --grade-run)
• .github/graders/architecture-guardian-operational-value-study.json — design record (designOutcome: accepted) with classification, decisions, and uncertainties
• .github/workflows/architecture-guardian.md — wires graders.operational-value
• .github/workflows/architecture-guardian.lock.yml — recompiled

Original prompt

[operational-value-study:paper-v1] architecture-guardian

Use the repository's .github/skills/operational-value-designer/SKILL.md to design
and verify one deterministic operational-value grader for github/gh-aw
workflow architecture-guardian. This is a fresh research run; do not copy another
workflow's metric or contract.

Requirements:

• Recover adoption-time intent and pre-adoption evidence independently.
• Use exactly one direct primary attainment metric in [0,1]. Keep diagnostics separate.
• Treat unavailable evidence as null, never zero. Make maturation explicit and stable.
• Support historical assignment reconstruction when case and event are null.
• If no direct operational metric is defensible, create only the study record below with designOutcome "blocked" and explain why. Never substitute activity, output volume, traces, or agent judgment.
• Change only .github/workflows/architecture-guardian.md, its generated lock file,
  .github/graders/architecture-guardian-operational-value.sh, and .github/graders/architecture-guardian-operational-value-study.json.
• Do not add generated historical reports to the pull request.

Write .github/graders/architecture-guardian-operational-value-study.json as JSON with this exact top-level shape:
{
"schemaVersion": 1,
"repository": "github/gh-aw",
"workflowId": "architecture-guardian",
"recordedAt": "ISO-8601 timestamp",
"recorder": "copilot-coding-agent",
"designOutcome": "accepted|rejected|blocked",
"rejectionReason": null,
"classification": {
"domain": "short research domain",
"subdomain": null,
"taskArchetype": "short label",
"interventionType": "short label",
"outcomeType": "short label",
"evidenceDirectness": "direct|proxy|activity",
"evidenceLocality": "same-repository|cross-repository|external",
"measurementLevel": "nominal|ordinal|interval|ratio",
"metricForm": "binary|proportion|rate|distance-to-target|index",
"assignmentDeterminism": "deterministic|bounded-ambiguity|ambiguous",
"intentExplicitness": "explicit|implicit|mixed",
"markdownSpecificity": "exact|bounded|open-ended",
"outcomeObservability": "immediate|delayed",
"causalClaim": "observational|comparative-not-causal"
},
"decisions": [{
"type": "intent|opportunity|assignment|evidence|maturation|metric|baseline|diagnostic",
"selected": "observable selected design",
"alternatives": ["observable rejected alternative"],
"rationale": "concise evidence-backed rationale, not hidden reasoning",
"evidenceReferences": ["commit, issue, PR, or file reference"],
"changedDuringReview": false
}],
"uncertainties": [{
"type": "measurement|assignment|evidence-availability|temporal|baseline|domain-fit|causal-attribution",
"level": "low|medium|high|unknown",
"description": "specific limitation",
"mitigation": null,
"evidenceReferences": []
}]
}

For blocked/rejected designs, rejectionReason must be a non-empty string. Record
observable contract choices and alternatives only; do not record chain-of-thought.

Validation for accepted designs:

1. .github/skills/operational-value-designer/scripts/verify-operational-value-evaluator.sh .github/graders/architecture-guardian-operational-value.sh
2. gh aw compile .github/workflows/architecture-guardian.md

Keep the pull request limited to this workflow. The local study runner will replay
history and archive reports after this task completes.

[github-actions]

🎉 Thanks for this contribution! This PR from the Copilot coding agent adds a deterministic operational-value grader for the architecture-guardian workflow—a well-researched addition that aligns perfectly with the project's agentic development approach.

Why this looks ready:

• ✅ Aligned with project process: The PR is authored by copilot-swe-agent, a trusted team member. Per the CONTRIBUTING.md, the project uses agentic development by the core team, and this follows that pattern.
• ✅ Focused scope: Changes are confined to the architecture-guardian workflow grader infrastructure (new grader script, study record, and workflow configuration updates).
• ✅ Well-documented: The PR body clearly explains the research, contract design decisions, and specific metrics (function decomposition, maturation window, evidence selection).
• ✅ Research-backed: References real workflow history, validated against actual remediation evidence, and explains design choices with clear rationale.
• ✅ On-topic: Implements operational-value evaluation, which is core to the project's agentic workflow infrastructure.

This is ready for maintainer review and merge!

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

• github.com

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "github.com"

See Network Configuration for more information.

Generated by ✅ Contribution Check · copilot · auto · 48.9 AIC · ⌖ 8.37 AIC · ⊞ 9.3K · ◷