Add East Asian charset mappings - #1763
Open
GtechGovind wants to merge 1 commit into
Open
Conversation
GtechGovind
marked this pull request as ready for review
September 3, 2026 06:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue: #228
Description
This PR adds Go decoder mappings for four MySQL character sets:
big5to Big5sjisto Shift-JISujisto EUC-JPeuckrto EUC-KRIt also adds table-driven regression tests with representative encoded byte sequences for each mapping.
Validation
go test -count=1 ./go/sqlgo vet ./go/sqlAll non-Docker packages pass with
go testscript/cibuildformats and builds successfully; its full test phase is blocked only in the existing Docker-backed logic suites because no rootless Docker provider is available in this environmentcontributed code is using same conventions as original code
script/cibuildreturns with no formatting errors, build errors or unit test errors.