Make it possible to run ./mvnw package instead of ./mvnw install. - #8659
Merged
Conversation
copybara-service
Bot
force-pushed
the
test_975713805
branch
from
September 4, 2026 19:50
55a3464 to
dcbbf53
Compare
This [just came up again](#8650 (comment)). It is a better solution to #2193 than #8127 was. (I think it makes sense for `gradle_integration_tests.sh` to continue using `install` so that the Maven-produced artifacts become visible to Gradle. But I haven't tested.) Sadly, it's still not enough for `mvn compile` to work: ``` [ERROR] Failed to execute goal on project guava-gwt: Could not resolve dependencies for project com.google.guava:guava-gwt:jar:999.0.0-HEAD-jre-SNAPSHOT [ERROR] dependency: com.google.guava:guava-testlib:jar:tests:999.0.0-HEAD-jre-SNAPSHOT (test) [ERROR] Could not find artifact com.google.guava:guava-testlib:jar:tests:999.0.0-HEAD-jre-SNAPSHOT [ERROR] dependency: com.google.guava:guava-tests:jar:tests:999.0.0-HEAD-jre-SNAPSHOT (test) [ERROR] Could not find artifact com.google.guava:guava-tests:jar:tests:999.0.0-HEAD-jre-SNAPSHOT ``` (For all testing of such changes, it's necessary to delete/move `~/.m2/repository/com/google/guava` so that Maven doesn't just read from previous builds that are installed there—thanks to our habit of using `mvn install` instead of `mvn package`!) RELNOTES=n/a PiperOrigin-RevId: 976459357
copybara-service
Bot
force-pushed
the
test_975713805
branch
from
September 4, 2026 20:10
dcbbf53 to
5fb424c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make it possible to run
./mvnw packageinstead of./mvnw install.This just came up again. It is a better solution to #2193 than #8127 was.
(I think it makes sense for
gradle_integration_tests.shto continue usinginstallso that the Maven-produced artifacts become visible to Gradle. But I haven't tested.)Sadly, it's still not enough for
mvn compileto work:(For all testing of such changes, it's necessary to delete/move
~/.m2/repository/com/google/guavaso that Maven doesn't just read from previous builds that are installed there—thanks to our habit of usingmvn installinstead ofmvn package!)RELNOTES=n/a