✨ periodic 피드백 실패 시 503 응답하도록 전용 예외 추가 - #38
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
문제
PeriodFeedbackService.summarize()에서 openAi.chatJson() 호출이
try 블록 밖에 있어, OpenAI 실패 시 IllegalStateException이
컨트롤러까지 그대로 전파됐다. GET /api/v1/feedback/periodic 호출 시
500 스택트레이스 노출.
변경
검증
참고
재시도 루프는 추가하지 않았습니다. periodic은 호출 빈도가 낮아
즉시 피드백과 같은 판단을 적용할 근거가 약해서요.
@서하 예외가 ai/port/에 들어가 있는데(기존 InstantFeedbackFailedException 위치를 따름),
port는 인터페이스 계약 패키지라 예외는 별도로 빼는 게 맞을지 의견 주세요.