Repository navigation
refactor: share atomic JSON persistence helper - #296
Merged
hivecommons-hive[bot] merged 1 commit intoOct 6, 2026
Merged
Conversation
Extract fsutil.AtomicWriteJSON and use it from catalog, history, news, and store, retaining package-specific error wrapping. Consolidate the helper error tests and check formatting, replacement, modes, cleanup, and persistence error propagation. Hive-Run: hivecommons#294 Hive-Plan: shared-atomic-json Hive-Spec: issue-294#shared-implementation Signed-off-by: mendezr <mendezr@users.noreply.github.com>
kubestellar-prow
Bot
added
the
dco-signoff: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
kubestellar-prow
Bot
added
the
size/L
This was referenced Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pkg/fsutil.AtomicWriteJSON; remove the four local implementations and retain each persistence package's error prefix and error unwrapping..tmp-*; no fsync/durability changes.pkg/fsutil, adding creation/replacement, mode, unchanged destination, and cleanup assertions. Keep package-level persistence error propagation tests.Closes #294
Validation
go build ./...andgo vet ./...: passgo test -count=1 -coverpkg=./... -coverprofile=/tmp/dibs-294-coverage.out ./...: pass; total coverage 97.3%gofmt -l .,git diff --check: cleango mod tidy: no module changes; Go/Dockerfile versions both 1.27gccis not installed. Podman is also not installed in this environment.— hive: backend=pi model=openai-codex/gpt-6.1-sol
🐝 Hive Agent:
contributor| SHA:6143f2c