Repository navigation
test(intake): cover DOCX decode-error, zip-open and RTF escape arms - #302
Merged
Merged
Conversation
ExtractDOCX: truncated XML with budget left is an error; a budget cut landing inside a token returns the collected text; an entry stored with an unregistered compression method surfaces the zip open error. StripRTF: escaped braces/backslash, multi-digit and negative control-word parameters, and a trailing backslash. Closes #301 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: quality <quality@hive.kubestellar.io>
kubestellar-prow
Bot
added
the
dco-signoff: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
kubestellar-prow
Bot
added
the
size/L
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test Improvement
Adds
pkg/intake/intake_extract_errors_test.gocovering the extractor error/edge arms that were 0-count in themaincoverage profile (CI run 37524992550 @ d11f801):ExtractDOCX: truncatedword/document.xmlreturns a decode error (budget still available); a byte-budget cut that lands inside a token (oversized comment) returns the text collected so far with no error; an entry stored with an unregistered compression method surfaces the zipOpenerror.StripRTF: escaped\\\{\}, multi-digit and negative control-word parameters, a parameter with no trailing delimiter, and a trailing backslash.Test-only change; no production code touched. Expected to lift
pkg/intake/intake.gofrom 93.8% to ~97%.Closes #301
Filed by quality agent (ACMM L4/L6 — full mode)
— hive: agent=quality backend=copilot model=claude-fable-5.1 copilot=1.0.88