Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #110
Related to horde/Core#234
Implement storage for per-service Oauth scopes and tokens.
@jcdelepine
The philosophy is like this:
Besides the already existing purpose "login", an OIDC provider may offer separate scopes to access services or resources, i.e. IMAP, SMTP, Caldav...
These purposes are centrally managed by an administrator along with the OIDC/OAuth setup.
I.e. the site administrator controls which OpenID providers/services can be used for "login with..." and also controls which email providers, addressbook providers etc this site's apps may access (provided the user has access)
Beyond the technical layer for OAuth, Horde doesn't care about each provider's scope names. We translate them to ServicePurposes fulfilled by ServiceAuthorizations. So each provider may have totally different scope names without affecting the applications.
Unfortunately neither with Microsoft nor Google the access to their OIDC backed APIs works out of the box. The site administrator needs to create IDs in Entra or Google Cloud Console for this integration to work. With your own Keycloak or other IdP this is not an issue but for smalltime users this might be a bummer.
Integration with IMP as a pilot will follow.