Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Saved global
localeData()objects currently mix their original week-start/formats with the current global locale's month and weekday names. Read all five name lists from the already-captured locale object, using the existing fallback helper.The regression switches French to English, checks all five saved lists, and confirms standalone
dayjs.months()still follows English.Validation: baseline passed; regression failed before the fix; 21 localeData/localizedFormat tests pass after it.
npm run lint,npm run babel(184 files), andgit diff --checkpass. Full timezone/browser matrices were not run.Self-review: limited to the localeData implementation and its regression test; no unrelated changes. Authored with OpenAI Codex assistance.
Fixes #3228.