Repository navigation
fix(serializers): prevent AttributeError and ObjectDoesNotExist in PluginConfigSerializer secret redaction. Closes #4052 - #4053
Open
harshitnub077 wants to merge 4 commits into
Conversation
…uginConfigSerializer secret redaction. Closes intelowlproject#4052 Signed-off-by: Harshit Kudhial <harshitkudhial@gmail.com>
…erializerTestCase The two new tests created DB states that clean_for_organization() forbids: - owner=None + for_organization=True raises ValidationError at PluginConfig.clean() - for_organization=True with an owner who has no membership also raises ValidationError Fix: - test_secret_no_owner_global_config: tests a valid global secret (owner=None, for_organization=False) to exercise the null-owner guard in get_attribute without hitting the DB constraint. - test_secret_redaction_owner_membership_removed_after_creation: creates the owner's membership first so the object saves, then deletes the membership to simulate a post-creation removal — the real scenario that previously raised ObjectDoesNotExist.
…Case after membership deletion
…organization on configs with membership-less owners
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When serializing a
PluginConfigwithis_secret=Trueandfor_organization=True,PluginConfigSerializer.CustomValueField.get_attributedirectly evaluatedinstance.owner.pkandinstance.owner.membership.organization.pk.This led to unhandled 500 exceptions in two scenarios:
AttributeError: 'NoneType' object has no attribute 'pk'wheninstance.ownerisNone(which is supported in the database constraints underapi_app/models.py).ObjectDoesNotExist: User has no membershipwheninstance.owneris set but lacks an active membership (e.g. users removed from an organization after the config was saved).requestor an authenticated user is missing from serializer context.This PR adds safe guards in
PluginConfigSerializer.CustomValueField.get_attribute(api_app/serializers/plugin.py):user.is_authenticatedandinstance.owneris notNonebefore comparinguser.pk == instance.owner.pk.user.has_membership(),user.membership.is_admin,instance.owner.has_membership(), and comparesorganization_iddirectly using the FK column — avoiding any.membershipattribute traversal that can raiseRelatedObjectDoesNotExist.PluginConfigSerializerTestCasecovering: global null-owner secrets, post-creation membership removal, and cross-organization visibility.Closes #4052
Type of change
Checklist
developdumpplugincommand and added it in the project as a data migration. ("How to share a plugin with the community")test_files.zipand you added the default tests for that mimetype in test_classes.py.FREE_TO_USE_ANALYZERSplaybook by following this guide.urlthat contains this information. This is required for Health Checks (HEAD HTTP requests).get_mocker_response()method of the unittest class. This serves us to provide a valid sample for testing.DataModelfor the new analyzer following the documentation# This file is a part of IntelOwl https://github.com/intelowlproject/IntelOwl # See the file 'LICENSE' for copying permission.Ruff) gave 0 errors. If you have correctly installed pre-commit, it does these checks and adjustments on your behalf.testsfolder). All the tests (new and old ones) gave 0 errors.DeepSource,Django Doctorsor other third-party linters have triggered any alerts during the CI checks, I have solved those alerts.Note on LLM assistance: An LLM was used to assist with static code analysis and drafting tests. All changes have been manually reviewed and verified against repository standards.