Skip to content

x4::char_set must be capable of propagating the constexpr-initialized variable to runtime #95

Description

@saki7

Currently, x4::char_set internally uses x4::detail::basic_chset which holds the internal buffer by x4::detail::char_range_run that uses std::vector.

In theory, this internal buffer can be totally constexpr if we do the parser construction in two phases and statically determine the maximum buffer amount in consteval preparation step (note: NOT constexpr). We can use std::inplace_vector (C++26; polyfill needed in iris-cpp/iris) for implementation details.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or requesttests neededUnit tests are required for all public API

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions