feat: Count override-affected evaluations separately and send no individual events for them - #219
Draft
kinyoklion wants to merge 1 commit into
Draft
kinyoklion wants to merge 1 commit into
kinyoklion wants to merge 1 commit into
Conversation
…vidual events for them The OVERRIDE specification marks an evaluation as override-affected when any definition it read came from the SDK's override store. Such an evaluation appears in summary events only: it produces no individual feature event and no debug event, whatever the flag's configuration requests, and it is counted in a separate summary counter that carries an overrideAffected marker so that override-affected and ordinary evaluations of the same flag, variation, and version are never collapsed together. Event.FeatureRequest carries the marking as a boolean that the SDK sets from its evaluation result. The existing constructors keep working and leave it false. DefaultEventProcessor keys individual event and debug event emission on it. EventSummarizer keeps a second set of counters per flag for marked evaluations, created on first use, and the output formatter writes overrideAffected only on those counters, like the unknown marker. EventSummarizerInterface gains the marker parameter and keeps the previous signature as a default method. Flag overrides are currently experimental and subject to change.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The OVERRIDE specification marks an evaluation as override-affected when any definition it read came from the SDK's override store. Such an evaluation appears in summary events only: it produces no individual feature event and no debug event, whatever the flag's configuration requests, and it is counted in a separate summary counter that carries an
overrideAffectedmarker, so override-affected and ordinary evaluations of the same flag, variation, and version are never collapsed together.Event.FeatureRequestcarries the marking as a boolean that the SDK sets from its evaluation result. The existing constructors keep working and leave it false;toDebugEvent()keeps the value.DefaultEventProcessorkeys individual feature event and debug event emission on the marking. Index events and summaries are unchanged.EventSummarizerkeeps a second set of counters per flag for marked evaluations, created on first use so unmarked flags pay nothing.EventOutputFormatterwritesoverrideAffected: trueonly on those counters, the same way theunknownmarker is written.EventSummarizerInterfacegains the marker parameter and keeps the previous signature as a default method that delegates with false.Flag overrides are currently experimental and subject to change. The server SDK change that sets the marking depends on the release of this package.