Skip to content

feat(AIC-3449): refactor AI Config reference into a dataclass - #113

Open
aknight-ld wants to merge 1 commit into
mainfrom
AIC-3449-refine-config-defs
Open

aknight-ld wants to merge 1 commit into
mainfrom
AIC-3449-refine-config-defs

Conversation

@aknight-ld

@aknight-ld aknight-ld commented Sep 25, 2026 •

Copy link
Copy Markdown
Contributor

Making the relationship between config and variation keys explicit for easier validation. No functional changes beyond this minor refactor.


Note

Overview
Breaking API change: EvaluationsModule.run() no longer accepts separate ai_config and variation string arguments. Callers must pass a single AIConfig(key=..., variation=...) frozen dataclass when seeding a run from an existing AI Config variation.

The new type is exported from launchdarkly_ai_server and launchdarkly_ai_server.evaluations. Validation now checks ai_config.key and ai_config.variation for blank values (replacing the old paired-parameter errors). Fetching, merging with generation, tools, judges, and logging behavior are unchanged aside from using the struct’s fields.

Reviewed by Cursor Bugbot for commit 2bb40bb. Bugbot is set up for automated code reviews on this repo. Configure here.

@aknight-ld
aknight-ld requested a review from donei003 September 25, 2026 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant