LIBRETRO: Initialize retro_message_ext and give notifications a severity - #116
Merged
spleen1981 merged 1 commit intoSep 19, 2026
Merged
Conversation
Collaborator
|
can you rebase please? Future PRs goes to |
The struct was filled in partly, so priority, level and progress reached the frontend as whatever was on the stack. Assisted-by: Claude:claude-opus-5
TRusselo
force-pushed
the
libretro-osd-severity
branch
from
September 18, 2026 22:47
8866779 to
78571e5
Compare
Author
|
Rebased on Noted on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
retro_osd_notification()fills in four fields of a stack-allocatedretro_message_extand leavespriority,levelandprogressuntouched, so they reach the frontend as whatever was on the stack.Zero-initialise the struct and take a level, so a frontend that ranks or filters messages gets a real value. Default is
RETRO_LOG_INFO, which is what the existing callers get without changing them.The eight call sites are classified:
RETRO_LOG_ERRORfor "Game not found" and "Failed to set up HW rendering",RETRO_LOG_WARNfor the folder-missing and HW-rendering-unavailable messages, default for the rest.Not Emscripten-specific -- this affects every target.