Show loading feedback on Toggle and Switch - #2828
Merged
Merged
Conversation
calebporzio
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a Toggle or Switch change triggers a Livewire request, provide pending feedback from
data-loading. Toggle replaces its contents with a centered spinner without changing its dimensions. Standard Switch uses its dimmed disabled appearance with no spinner. Both suppress pointer interaction while pending.The companion switch JavaScript change blocks keyboard and label activation and exposes busy/disabled accessibility state, while preserving focus and the existing disabled attribute. The docs demonstrate
wire:model="active" wire:change="save".Validation: 28 focused Switch/Toggle browser tests pass. Rebuilt assets and verified both controls in the Laravel playground plus the real Flux docs example, including loading cleanup, single saves, unchanged geometry, and retained keyboard focus. Generated bundles are left for the release build.
Companions: https://github.com/livewire/flux-pro/pull/584 and https://github.com/livewire/flux-docs/pull/230.