[28.x] Remove Microsoft Managed background GuiCheck in Azure OpenAI - #10455
[28.x] Remove Microsoft Managed background GuiCheck in Azure OpenAI#10455Darrick (darjoo) wants to merge 1 commit into
Conversation
Microsoft Managed Copilot capabilities no longer require a GUI session, so the GuiAllowed guard and its CapabilityBackgroundErr label are removed. The API/OData client type check is unchanged. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
Good Sense Reviewer - Round 1Recommendation: Accept with SuggestionsWhat this PR doesThis servicing change removes the Azure OpenAI guard that blocked Microsoft Managed Copilot capabilities when the current session had no GUI. It leaves the existing API, OData, SOAP, and Management client-type rejection in place. The diff is very narrow: only the background Problem-solution fitFit: Strong The requested behavior is to allow Microsoft Managed Copilot capabilities from background sessions while still blocking unsupported service client types. The code does exactly that by removing only the stale background guard. SuggestionsS1 (🟠 Moderate): Cover the new background-session behavior Risk assessment and necessityRisk: Moderate. The change expands where Microsoft Managed Azure OpenAI calls can run, including job queue or other non-GUI sessions. The remaining client-type guard limits the broader service-surface risk. Necessity: Justified if Microsoft Managed capabilities are now supported in background sessions. The narrow deletion is appropriate for a release-branch backport, but a regression test would make the behavior safer to service.
|
Summary
What & why
AzureOpenAIImpl.GuiCheckblocked Microsoft Managed Copilot capabilities from running wheneverGuiAllowed()was false, erroring with "Microsoft Copilot Capabilities are not allowed in the background." That restriction is no longer valid, so the guard is removed along with its now-unusedCapabilityBackgroundErrlabel.This is a backport to
releases/28.xof the same change made onmainin #10452.The rest of
GuiCheckis untouched: it still exits early for Self-Managed resource utilization and still errors on Api, OData, ODataV4, SOAP, and Management client types viaCapabilityODataErr.How I validated this
What I tested and the outcome
GuiAllowed()guard inGuiCheckplus theCapabilityBackgroundErrlabel declaration.CapabilityBackgroundErrand for the "not allowed in the background" message; there are no other references anywhere in the repo.Risk & compatibility
CapabilityBackgroundErrlabel is removed. It was a local label in an internal implementation codeunit, so this is not a breaking API or extension-facing change, though the string will drop out of translation files on the next regeneration.Work Item(s)
Linked work
Fixes AB#647415