Skip to content

Allow bank rec. duplicated transactions surfaced in UI - #11055

Open
Joshua (mynjj) wants to merge 2 commits into
mainfrom
bugs/bankrec-allow-duplicated-transactions-ui
Open

Allow bank rec. duplicated transactions surfaced in UI#11055
Joshua (mynjj) wants to merge 2 commits into
mainfrom
bugs/bankrec-allow-duplicated-transactions-ui

Conversation

@mynjj

@mynjj Joshua (mynjj) commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

We already had a functionality that unblocks several scenarios when importing bank statements. However, there was no UI surface for it.

This change resurfaces this functionality, to give this option to users that need it. In particular, this was discovered when a DE customer was trying to import SEPA CAMT files, that have Transaction ID coming from EndToEndId, which I validated in https://www.iso20022.org/iso-20022-message-definitions?scope%5B0%5D=messages&search=camt MDR part 3 that the uniqueness in enforced by the initiator of the transaction, making imports with same id under the same file plausible.

Used the opportunity to change the captions to something a bit more precise.

Fixes AB#648907

Joshua Martínez Pineda added 2 commits September 4, 2026 14:00
@mynjj
Joshua (mynjj) requested a review from a team September 4, 2026 12:16
@mynjj
Joshua (mynjj) requested a review from a team as a code owner September 4, 2026 12:16
@github-actions github-actions Bot added the Team: Finance GitHub request for Finance area label Sep 4, 2026
@github-actions github-actions Bot added this to the Version 30.0 milestone Sep 4, 2026
@alexei-dobriansky

Copy link
Copy Markdown
Contributor

Good Sense Reviewer - Round 1

Recommendation: Accept with Suggestions

What this PR does

The change exposes the existing Allow Duplicated Transactions setting in the bank reconciliation UI. It adds a Process action on the Payment Reconciliation Journal pages, adds the field to the Bank Acc. Reconciliation card so it can be personalized, and updates the caption and tooltip text.

The action reads the current reconciliation header, asks for confirmation, validates the inverse value, and modifies the header. That matches the existing import logic, which reads the same header field before it decides whether duplicate transaction IDs may be imported. The W1 and CH payment journal copies are aligned, and the W1 and NA table/card copies are aligned.

Problem-solution fit

Fit: Strong

The reported problem is that the duplicate-transaction import setting already exists but is not easy to set from the product UI. This change gives users a supported UI path to change that setting before import, while leaving the existing duplicate-import logic unchanged.

Suggestions

S1 (🟠 Moderate): Add a test for the toggle action
Please add a small page test for the new action that accepts the confirmation and verifies that the header flag changes both ways. Existing import tests cover the table flag, but not the action that users will click.

S2 (🟡 Minor): Clarify the enabled-state confirmation text
When the setting is on, the message says duplicate transactions are currently "considered". Use "imported" instead in both page copies. That makes the Yes/No choice match the action caption.

Risk assessment and necessity

Risk: The regression surface is limited to page metadata and a new UI action. The import decision still uses the existing table field and existing import code, so the main financial/reconciliation behavior is unchanged. The main risk is that the new action could be broken or confusing, which is why a small UI action test and clearer confirmation text would help.

Necessity: The change is needed because some valid bank statement files can contain repeated transaction IDs, and the product already has logic to allow that case. The scope is narrow: it surfaces an existing setting instead of changing the duplicate detection algorithm.


[AI-PR-REVIEW] version=1 promptVersion=4 system=github pr=11055 round=1 by=alexei-dobriansky at=2026-09-04T13:59:32Z lastSha=3216d5605357c0535808f3e6091e19a251aaf6ad reviewKey=f7adce358e9a8d497843279592b91ab44ef1c4305017de715e3d85529cee828d suggestions=S1@48f67fc9,S2@73873811

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Team: Finance GitHub request for Finance area

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants