Allow bank rec. duplicated transactions surfaced in UI - #11055
Allow bank rec. duplicated transactions surfaced in UI#11055Joshua (mynjj) wants to merge 2 commits into
Conversation
Good Sense Reviewer - Round 1Recommendation: Accept with SuggestionsWhat this PR doesThe change exposes the existing The action reads the current reconciliation header, asks for confirmation, validates the inverse value, and modifies the header. That matches the existing import logic, which reads the same header field before it decides whether duplicate transaction IDs may be imported. The W1 and CH payment journal copies are aligned, and the W1 and NA table/card copies are aligned. Problem-solution fitFit: Strong The reported problem is that the duplicate-transaction import setting already exists but is not easy to set from the product UI. This change gives users a supported UI path to change that setting before import, while leaving the existing duplicate-import logic unchanged. SuggestionsS1 (🟠 Moderate): Add a test for the toggle action S2 (🟡 Minor): Clarify the enabled-state confirmation text Risk assessment and necessityRisk: The regression surface is limited to page metadata and a new UI action. The import decision still uses the existing table field and existing import code, so the main financial/reconciliation behavior is unchanged. The main risk is that the new action could be broken or confusing, which is why a small UI action test and clearer confirmation text would help. Necessity: The change is needed because some valid bank statement files can contain repeated transaction IDs, and the product already has logic to allow that case. The scope is narrow: it surfaces an existing setting instead of changing the duplicate detection algorithm.
|
We already had a functionality that unblocks several scenarios when importing bank statements. However, there was no UI surface for it.
This change resurfaces this functionality, to give this option to users that need it. In particular, this was discovered when a DE customer was trying to import SEPA CAMT files, that have Transaction ID coming from EndToEndId, which I validated in https://www.iso20022.org/iso-20022-message-definitions?scope%5B0%5D=messages&search=camt MDR part 3 that the uniqueness in enforced by the initiator of the transaction, making imports with same id under the same file plausible.
Used the opportunity to change the captions to something a bit more precise.
Fixes AB#648907