Skip to content

29.x: Allow bank rec. duplicated transactions surfaced in UI - #11056

Open
Joshua (mynjj) wants to merge 2 commits into
releases/29.xfrom
bugs/649134-29.x
Open

29.x: Allow bank rec. duplicated transactions surfaced in UI#11056
Joshua (mynjj) wants to merge 2 commits into
releases/29.xfrom
bugs/649134-29.x

Conversation

@mynjj

@mynjj Joshua (mynjj) commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

We already had a functionality that unblocks several scenarios when importing bank statements. However, there was no UI surface for it.

This change resurfaces this functionality, to give this option to users that need it. In particular, this was discovered when a DE customer was trying to import SEPA CAMT files, that have Transaction ID coming from EndToEndId, which I validated in https://www.iso20022.org/iso-20022-message-definitions?scope%5B0%5D=messages&search=camt MDR part 3 that the uniqueness in enforced by the initiator of the transaction, making imports with same id under the same file plausible.

Used the opportunity to change the captions to something a bit more precise.

Fixes AB#649134

Joshua Martínez Pineda added 2 commits September 4, 2026 14:20
@mynjj
Joshua (mynjj) requested a review from a team September 4, 2026 12:21
@mynjj
Joshua (mynjj) requested a review from a team as a code owner September 4, 2026 12:21
@github-actions github-actions Bot added the Team: Finance GitHub request for Finance area label Sep 4, 2026
@github-actions github-actions Bot added this to the Version 29.1 milestone Sep 4, 2026
@alexei-dobriansky

Copy link
Copy Markdown
Contributor

Good Sense Reviewer - Round 1

Recommendation: Accept with Suggestions

What this PR does

This change exposes an existing bank reconciliation setting that lets statement imports keep transactions with duplicate transaction IDs instead of skipping them. It adds the setting to reconciliation pages, adds a confirmation action on the payment reconciliation journal, and updates the caption and tooltip text.

The backend import behavior was already present and covered by existing import tests. The new action initializes the current reconciliation, confirms the change, then validates and modifies the same header field that the import code reads, so the chosen value is used by the existing import path.

Problem-solution fit

Fit: Strong

The reported problem is that valid bank files can contain repeated transaction IDs, but the available setting was not reachable enough from the UI. The change keeps default behavior unchanged and lets users opt in before running the existing import process.

Suggestions

S1 (🟠 Moderate): Add coverage for the toggle action
Add a small page test for the new action. It should confirm that the Yes path changes Bank Acc. Reconciliation.Allow Duplicated Transactions and the No path leaves it unchanged, so this UI surface cannot regress while the import tests still pass.

S2 (🟡 Minor): Make the disable prompt clearer
Change the disable confirmation to say duplicate transactions are currently imported, not considered. This makes the toggle state clear before a user turns the option off.

Risk assessment and necessity

Risk: The change is in bank reconciliation import UI and updates a header setting that affects which statement lines are imported. The default remains false, so existing imports continue to skip duplicates unless a user opts in. No public API or event surface changes are involved, and the relevant page variants were updated consistently.

Necessity: The change is justified because duplicate transaction IDs can be valid in real bank files, and the behavior already existed without a practical UI entry point. The scope is small and limited to surfacing that setting.


[AI-PR-REVIEW] version=1 promptVersion=4 system=github pr=11056 round=1 by=alexei-dobriansky at=2026-09-04T13:59:32Z lastSha=ecce51e29492c2161ccdafb703fea91ccc256a1f reviewKey=8a12196b9cfc8f757981169607108badedc97243d1c60f2b4922392b6847f3a7 suggestions=S1@9afbb40e,S2@7bd8b157

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Team: Finance GitHub request for Finance area

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants