Backport #9430: [28.x] E-Document ADI import crashes with untrappable JSON error when ADI response lacks outputs.1 structure - #9901
Open
ventselartur wants to merge 1 commit into
Conversation
## Why The E-Document Matching Assistance (ADI) import path in `EDocument Json Helper` read properties from the ADI response using `JsonObject.Get(...)` without checking the boolean return value. When the Azure Document Intelligence response was malformed or missing an expected property (`outputs`, `1`, `result`, or `fields`), the subsequent `JsonToken.AsObject()` call operated on an uninitialized token, raising an untrappable runtime error that crashed the import instead of degrading gracefully. ## Summary - **Fixed** the untrappable JSON error by guarding every `Get` call in `GetInnerObject` and `GetHeaderFields`; when an expected property is absent the helper now returns an empty `JsonObject` instead of dereferencing an uninitialized token. - **Added** telemetry (`0000UK1`-`0000UK4`, Warning) under the "E-Document Matching Assistance" category so malformed ADI responses are diagnosable, with a locked label naming the missing property. [AB#640122](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/640122) --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
github-actions
Bot
added
AL: Apps (W1)
Contributor
Good Sense Reviewer - Round 1Recommendation: Request Changes This is a faithful code port of #9430 into 28.x, and it does prevent the missing-key crash. But it still leaves the malformed-shape case open, so the stated ADI crash fix is not complete. Suggestions
Risk & necessityThis backport is worth taking because the current 28.x code can crash on malformed ADI responses in a user-facing import path. If it ships as-is, some malformed responses will still crash instead of degrading gracefully, so the risk is reduced but not removed.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #9430 for AB#644118