Fix preinstall failure when repo path contains spaces - #334529
Open
Fahad Iftikhar (Fahad090NP) wants to merge 2 commits into
Open
Fix preinstall failure when repo path contains spaces#334529Fahad Iftikhar (Fahad090NP) wants to merge 2 commits into
Fahad Iftikhar (Fahad090NP) wants to merge 2 commits into
Conversation
Copilot started reviewing on behalf of
Fahad Iftikhar (Fahad090NP)
September 4, 2026 15:41
View session
Author
|
Context: this PR replaces #329203, which was closed automatically when my fork was deleted from GitHub. GitHub cannot reopen a PR whose head repository was deleted, so the branch was rebuilt from the original commits (same commit messages and authorship) on top of the current main. Maintainers: please judge this PR in place of the closed #329203. Thank you! |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused change correctly avoids shell path splitting across platforms.
Pull request overview
Fixes preinstall header installation when the repository path contains spaces.
Changes:
- Invokes
node-gyp.jsdirectly through Node. - Removes shell-based argument handling.
File summaries
| File | Description |
|---|---|
build/npm/preinstall.ts |
Uses discrete process arguments for reliable path handling. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
npm installfails during the preinstall step when the repository ischecked out at a path containing spaces (e.g.
.../My Projects/vscode):Restored PR: This replaces #329203, which was closed automatically when my fork was deleted from GitHub. GitHub cannot reopen a PR whose head repository was deleted, so the branch was rebuilt from the original commits (same commit messages and authorship) on top of the current
main. Please review this PR in place of #329203.