build: override product Copilot runtime - #334609
Closed
roblourens wants to merge 4 commits into
Closed
Conversation
Update the bundled root and remote dependencies to the requested canary builds. Accept the SDK's policyHelper managed-settings source in diagnostics and E2E validation.\n\n(Written by Copilot)\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
Dependency sets, lockfiles, diagnostics typing, and E2E validation are consistent.
Review tier: Balanced
Findings: None
What changed in this PR
Updates bundled Copilot SDK/CLI canaries and recognizes the runtime’s new managed-settings diagnostic source.
Changes:
- Synchronizes Copilot package versions across root and remote dependencies.
- Adds
policyHelperto the diagnostic source contract and E2E validation.
| File | Description |
|---|---|
package.json |
Updates root Copilot dependencies. |
package-lock.json |
Locks root dependencies and platform binaries. |
remote/package.json |
Updates remote Copilot dependencies. |
remote/package-lock.json |
Locks remote dependencies and platform binaries. |
src/vs/platform/agentHost/common/agent.ts |
Extends the managed-settings source type. |
src/vs/platform/agentHost/test/node/e2e/suites/managementExtensionsSuite.ts |
Accepts the new source in diagnostics testing. |
Files not reviewed (1)
- remote/package-lock.json: Generated file
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Restore the public Copilot dependency pins used by OSS builds. Product builds can apply the requested private-feed SDK and CLI canaries through the existing Azure pipeline override parameters.\n\n(Written by Copilot)\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
roblourens
changed the title
Use a checked-in manifest as the default source for Copilot SDK and CLI versions in Azure product builds while keeping OSS package manifests on public versions. Retain queue-time selectors as recovery and validation escape hatches.\n\n(Written by Copilot)\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
roblourens
changed the title
Keep the OSS SDK version and check in the product runtime canary as the existing Azure pipeline parameter default. Extend the shared override path to support runtime-only updates.\n\n(Written by Copilot)\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Member
Author
|
Superseded by the clean (Written by Copilot) |
roblourens
changed the title
Member
Author
|
Replacing this fork-headed PR with an upstream (Written by Copilot) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@github/copilotand@github/copilot-sdkversions1.0.84-canary.66.g9267bf0.unsignedas the default product@github/copilotruntime versionpolicyHelpermanaged-settings diagnostics sourceImplementation
The existing
VSCODE_CLI_CANARY_VERSIONparameter remains the product-build override mechanism, but its checked-in default is now the desired runtime canary.VSCODE_SDK_CANARY_VERSIONstaysnone, so product builds retain the SDK from the OSS manifest. The shared pre-cache step now runs when either override is present and refreshes only the dependency that changed.Validation
cd build && npm run typechecknpm run typecheck-clientnpm run hygieneThe requested
1.0.84-canary.66.g9267bf0.unsignedpackage is not yet visible on the private feed, so an Azure product build with that exact runtime cannot succeed until it is published.Main-branch counterpart of #334645.
(Written by Copilot)