Skip to content

Read "WEB_FIXTURES_BROWSER" from "$_SERVER" consistently - #415

Open
aik099 wants to merge 1 commit into
minkphp:masterfrom
aik099:browser-name-from-server-var
Open

aik099 wants to merge 1 commit into
minkphp:masterfrom
aik099:browser-name-from-server-var

Conversation

@aik099

@aik099 aik099 commented Oct 5, 2026 •

Copy link
Copy Markdown
Member

The WEB_FIXTURES_BROWSER was read via getenv() when creating the driver, but via $_SERVER in the testDragDropOntoHiddenItself skip check. Since <server name="WEB_FIXTURES_BROWSER" .../> in phpunit.xml only populates $_SERVER, a locally configured browser was ignored by the driver (it always used firefox), while the skip check saw the configured one.

The CI wasn't affected, because there the value comes from a real env var, which is visible to both.

Now both places use $_SERVER (with firefox default), like all other test config variables do.

Also noted in phpunit.xml.dist, that SELENIUM_VERSION and WEB_FIXTURES_BROWSER must stay commented-out there, because a <server> entry overwrites the env var given by the CI.

Related: minkphp/webdriver-classic-driver#44

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@codecov

codecov Bot commented Oct 5, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.42%. Comparing base (d8b1d4e) to head (18c94ae).

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #415   +/-   ##
=========================================
  Coverage     85.42%   85.42%           
  Complexity      184      184           
=========================================
  Files             1        1           
  Lines           501      501           
=========================================
  Hits            428      428           
  Misses           73       73           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant