Grant koic direct maintainers role for spec repo push access - #178
Merged
Conversation
koic (Koichi Ito, Ruby SDK maintainer) only held ROLE_IDS.RUBY_SDK, which maps to the ruby-sdk GitHub team with triage on the modelcontextprotocol spec repo. The SDK_MAINTAINERS -> MAINTAINERS implication is discordImplies-only and does not add members to the maintainers GitHub team, so he could not push branches or open PRs in the spec repo. Add ROLE_IDS.MAINTAINERS directly, matching other maintainer entries. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01H4JKj5FVkmj6bRzgh1GPrY
Pulumi PreviewClick to expand preview output |
localden
approved these changes
Sep 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Den Delimarsky · Slack thread
Before:
koic(Koichi Ito, Ruby SDK maintainer) holds onlyROLE_IDS.RUBY_SDKinsrc/config/users.ts, which puts him in theruby-sdkGitHub team — and that team has onlytriageon themodelcontextprotocolspec repo (src/config/repoAccess.ts:124). Thesdk-maintainers -> maintainersimplication (roles.ts:197) isdiscordImplies-only: GitHub team memberships are built solely from directmemberOfentries (src/github.ts:54-61), so he never landed in themaintainersGitHub team that carriespushon the spec repo (repoAccess.ts:118). With triage-only access he cannot push branches, and therefore cannot create PRs in the spec repo.After:
koicis a direct member ofROLE_IDS.MAINTAINERS, so he joins themaintainersGitHub team and getspushonmodelcontextprotocol/modelcontextprotocol(pluspullon maintainer-docs), letting him push branches and open PRs like the other general maintainers.How: Adds
ROLE_IDS.MAINTAINERSto koic'smemberOfinsrc/config/users.ts, matching the ordering convention of other maintainer entries (MAINTAINERS listed first). No Google Workspace account is provisioned — GWS is opt-in viafirstName/lastName/googleEmailPrefix, which his entry does not set.npm run checkpasses locally (format, validate, 33 tests). Note: the change takes effect on the next deploy tomain; if his org membership were pending/lapsed (invites expire after 7 days), team membership would additionally need a fresh invite acceptance.🤖 Generated with Claude Code
https://claude.ai/code/session_01H4JKj5FVkmj6bRzgh1GPrY
Generated by Claude Code