stream: destroy source when map iterator closes early - #64264
Merged
nodejs-github-bot merged 1 commit intoSep 7, 2026
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
needs-ci
Contributor
Author
|
@jasnell Could you please help review this? Thanks! |
jasnell
reviewed
Jul 9, 2026
ronag
approved these changes
Jul 9, 2026
ronag
added
the
semver-major
benjamingr
approved these changes
Jul 9, 2026
jasnell
approved these changes
Jul 12, 2026
mcollina
added
the
request-ci
github-actions
Bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
trivikr
added
request-ci
github-actions
Bot
added
request-ci-failed
Contributor
Failed to start CI- Validating Jenkins credentials ✔ Jenkins credentials valid - Querying data for job/node-test-pull-request/74793/ SyntaxError: Unexpected token '<', ..." https://github.com/nodejs/node/actions/runs/32604643614 |
trivikr
removed
the
request-ci-failed
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Member
Y1D7NG
force-pushed
the
fix-stream-find-some-every-destroy
branch
from
September 6, 2026 15:46
963b76e to
457b5cb
Compare
Fixes: nodejs#64261 Signed-off-by: y1d7ng <y1d7ng@yeah.net>
Y1D7NG
force-pushed
the
fix-stream-find-some-every-destroy
branch
from
September 6, 2026 16:12
457b5cb to
a28f607
Compare
Contributor
Author
trivikr
approved these changes
Sep 6, 2026
trivikr
added
the
request-ci
gurgunday
approved these changes
Sep 6, 2026
github-actions
Bot
removed
the
request-ci
Collaborator
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #64264 +/- ##
==========================================
+ Coverage 90.19% 90.20% +0.01%
==========================================
Files 771 771
Lines 264622 264621 -1
Branches 50223 50224 +1
==========================================
+ Hits 238663 238710 +47
+ Misses 16965 16906 -59
- Partials 8994 9005 +11
🚀 New features to boost your workflow:
|
panva
added
the
commit-queue
Collaborator
|
Landed in 9f7ae86 |
nodejs-github-bot
removed
the
commit-queue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #64261
When some(), every(), or find() returns early, the underlying map() iterator closes but the source stream is never destroyed, leaving it open and preventing cleanup. The fix calls destroyImpl.destroyer(stream, null) in the map() iterator cleanup path so the source stream is destroyed when the iterator closes early.