Skip to content

deps: V8: use a 128-bit multiply in rapidhash secret generation #65795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
colinhacks wants to merge 1 commit into from
+10 −1
Closed

deps: V8: use a 128-bit multiply in rapidhash secret generation #65795

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion common.gypi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@

# Reset this number to 0 on major V8 upgrades.
# Increment by one for each non-official patch applied to deps/v8.
'v8_embedder_string': '-node.29',
'v8_embedder_string': '-node.30',

##### V8 defaults for Node.js #####

Expand Down
2 changes: 2 additions & 0 deletions deps/v8/third_party/rapidhash-v8/README.chromium
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,3 +19,5 @@ particular version is copied over from Chromium.
Local Modifications:
- Copied over from Chromium's third_party/rapidhash with all its changes.
- Removed base/ includes and replaced with V8 versions.
- mul_mod in secret.h uses a 128-bit multiply and modulo where the compiler
runtime provides one.
7 changes: 7 additions & 0 deletions deps/v8/third_party/rapidhash-v8/secret.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,12 @@ static inline uint64_t wyrand(uint64_t* seed) {
static inline unsigned long long mul_mod(unsigned long long a,
unsigned long long b,
unsigned long long m) {
#if defined(__SIZEOF_INT128__) && !defined(_WIN32)
// A 128-bit multiply and modulo lower to __umodti3 from compiler-rt, which
// clang's Windows runtime does not provide.
return static_cast<unsigned long long>(
(static_cast<__uint128_t>(a) * b) % m);
#else
unsigned long long r = 0;
while (b) {
if (b & 1) {
Expand All @@ -96,6 +102,7 @@ static inline unsigned long long mul_mod(unsigned long long a,
}
}
return r;
#endif
}

static inline unsigned long long pow_mod(unsigned long long a,
Expand Down
Loading