You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
OAuth2 / OpenID Connect authentication for DICOMweb and Viewer Hub used the Scribejava library. It brought its own HTTP client and thread pool, duplicated what the built-in JavaNetHttpClient already provides, and made it difficult to apply the request stall guard introduced for #899.
OAuth2ServiceFactory and the authorization-code / client-credentials flows are reimplemented on top of JavaNetHttpClient. Consequences:
The scribejava 8.3.3 dependency and its IDEA external annotations are removed.
The request stall guard is ported onto the new client: the request half of an exchange is bounded by time without progress (inactivityTimeout) instead of a whole-exchange deadline, so a large STOW-RS send on a slow link is only aborted when bytes stop flowing.
The getConnectTimeout / getReadTimeout aliases deprecated in 4.7.3 are removed in favour of getConnectTimeoutMillis / getInactivityTimeoutMillis.
Description
OAuth2 / OpenID Connect authentication for DICOMweb and Viewer Hub used the Scribejava library. It brought its own HTTP client and thread pool, duplicated what the built-in
JavaNetHttpClientalready provides, and made it difficult to apply the request stall guard introduced for #899.OAuth2ServiceFactoryand the authorization-code / client-credentials flows are reimplemented on top ofJavaNetHttpClient. Consequences:scribejava8.3.3 dependency and its IDEA external annotations are removed.inactivityTimeout) instead of a whole-exchange deadline, so a large STOW-RS send on a slow link is only aborted when bytes stop flowing.getConnectTimeout/getReadTimeoutaliases deprecated in 4.7.3 are removed in favour ofgetConnectTimeoutMillis/getInactivityTimeoutMillis.