Fix: deploy workflow could publish a non-main branch to production - #97
Merged
nabobalis merged 1 commit intoAug 26, 2026
Merged
Conversation
nabobalis
approved these changes
Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #96
Problem
The
deployjob'sifcondition let a manualworkflow_dispatchrun bypass themain-branch check entirely:Because of the original
||, dispatching the workflow on any branch satisfied the condition and this job deploys withcontents: write+force_orphan: true(which wipesgh-pageshistory), so an accidental manual run from the wrong branch would overwrite the live site with unreviewed content and destroy the previous deployment history.Change
Require
ref_name == 'main'unconditionally, for bothpushandworkflow_dispatchtriggers.pushbehavior is unchanged. Manual redeploys viaworkflow_dispatchstill work exactly as before, as long as they're triggered onmainthey just can no longer target other branches.Type of change