add errors for file size - #918
Merged
Merged
Conversation
mccalluc
marked this pull request as ready for review
July 7, 2026 16:40
| reported size: 1048576 | ||
| blocks used: 0 | ||
| """ | ||
| f = path.open("ab") |
Contributor
There was a problem hiding this comment.
with path.open("ab") as f:
f.truncate(size_in_mb * 1024 * 1024)
Contributor
There was a problem hiding this comment.
Generally prefer to use with blocks here. They protect against more error cases
Contributor
There was a problem hiding this comment.
It will call the close in the end so that line could be removed
| def test_get_csv_names_mismatch(): | ||
| with tempfile.TemporaryDirectory() as tmp: | ||
| with TemporaryDirectory() as tmp: | ||
| a_path = Path(tmp) / "a.csv" |
Contributor
There was a problem hiding this comment.
I have written path.join so many times, this syntax is a lot better
| ... print('blocks used:', path.stat().st_blocks) | ||
| reported size: 1048576 | ||
| blocks used: 0 | ||
| """ |
Contributor
There was a problem hiding this comment.
lgtm after the with block here
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.