Skip to content

fix(place): disable pin inflation and lower default padding - #321

Merged
Yell-walkalone merged 1 commit into
mainfrom
codex/default-placement-defaults-200
Oct 5, 2026
Merged

Yell-walkalone merged 1 commit into
mainfrom
codex/default-placement-defaults-200

Conversation

@zhaoxueyan1

Copy link
Copy Markdown
Member

Problem

The ECC DreamPlace defaults still enabled pin-density inflation with pin_density=0.6 and requested cell_padding_x=300. That combination adds geometry inflation before placement even when the user has not explicitly enabled pin inflation.

Change

  • Set pin_density to -1, which keeps pin-density inflation disabled unless a workspace explicitly supplies a value in (0, 1).
  • Reduce the default cell_padding_x from 300 to 200 for the ICS55/general DreamPlace defaults.
  • Keep the parameter schema, generated DreamPlace JSON, tests, and English/Chinese configuration documentation consistent.

The existing SG13G2-specific template default of cell_padding_x=0 is unchanged.

Validation

  • pytest -q test/data/test_design_parameters.py test/formal/test_param_propagation.py test/cli/params/test_registry.py
    • 416 passed, 3 skipped, 1 xfailed
  • Parsed dreamplace_ecc.json successfully and verified the effective defaults are cell_padding_x=200 and pin_density=-1.
  • git diff --check

Copilot AI balanced review requested due to automatic review settings October 5, 2026 05:35

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@Yell-walkalone
Yell-walkalone merged commit 0be9c0e into main Oct 5, 2026
15 checks passed
sashimi-yzh added a commit that referenced this pull request Oct 5, 2026
* Previously there is still something wrong in ecc-dreamplace
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants