Geometry debug function - #4012
Merged
paulromano merged 43 commits intoSep 5, 2026
Merged
Conversation
paulromano
requested changes
Jul 14, 2026
paulromano
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the initial shot at this! Here are my initial thoughts:
Contributor
Author
|
Thanks for checking it out @paulromano. I have added some updates for the bounding box idea for both overlapping and undefined regions, including a warning if undefined regions are under-resolved. Let me know what you think. |
viktormai
marked this pull request as ready for review
July 22, 2026 15:10
paulromano
requested changes
Jul 22, 2026
paulromano
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the updates @viktormai! Here is another round of comments:
paulromano
requested changes
Aug 13, 2026
paulromano
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the updates @viktormai! This is getting closer. Now that it is looking better, you should also add some unit tests for the capability to ensure it works properly.
paulromano
approved these changes
Sep 5, 2026
paulromano
left a comment
Contributor
There was a problem hiding this comment.
All set now; thanks @viktormai!
paulromano
enabled auto-merge (squash)
September 5, 2026 22:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a 3D geometry debugging utility to Model for identifying overlap and undefined regions within an OpenMC geometry by sampling a user-defined bounding box.
Main changes
Added Model.geometry_debug():
Added _classify_undefined_regions() helper:
This pair of functions provides a simple way to locate common geometry construction problems—particularly overlaps and enclosed undefined regions—by returning representative coordinates that users can inspect directly, rather than relying solely on transport failures or visual inspection. These sample points can also be leveraged by AI agents to easily fix geometry issues in the model. Reusable undefined-region classification logic that can be leveraged by future plotting and geometry diagnostics for plotting undefined regions is also established.
Checklist