fix(plugin-multi-tenant): preserve form after refused tenant save - #18131
Open
MALLADISARMA wants to merge 1 commit into
Open
fix(plugin-multi-tenant): preserve form after refused tenant save#18131MALLADISARMA wants to merge 1 commit into
MALLADISARMA wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #18122
What?
Prevent the tenant selector from refreshing the route when tenant options are synchronized but have not changed.
Why?
When no tenant is selected, saving a tenant document that fails validation triggers
syncTenants(). The refreshed tenant options array changed thesetTenantcallback identity, causing the provider effect to callrouter.refresh(). This refreshed the create page and cleared the user's form values.How?
Updated
syncTenants()to compare tenant option IDs before updating state. When the IDs are unchanged, the existing options array is preserved, keeping the callback identity stable and preventing the unnecessary route refresh.This preserves the entered form values after a refused save while retaining the existing tenant synchronization behavior.
Testing