Repository navigation
feat(scan): support custom models with one selected analyzer - #68
Merged
Merged
Conversation
picatz
marked this pull request as ready for review
October 9, 2026 01:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
taint scanthrough the shared loader and detector options.-modelsis supplied (including an explicit empty value). Modelkindlabels remain informational; findings retain the selected analyzer's identity.-C, without process-wide chdir.Regression coverage
Synthetic tests cover file/directory/absolute/relative paths, flag order, empty/missing/malformed/schema-invalid models, all six analyzer identities, source/sink/sanitizer/summary controls, built-in additive findings, model isolation between runs, exact same-module limits, selected dependency occurrence boundaries, and text/JSON/SARIF output. Process smoke checks verify exits 0/1/3 for all formats.
Validation
319ee537passed all eight hosted checks. Terminal logs confirm full suites on Go 1.26.9/1.27.2, root/callgraph race on Go 1.27.2 (222 groups), and wholeprogram/CLI race on Go 1.27.2 (53 groups). CI run.Inherited CI compatibility repairs
The old preferred Go 1.27.1 toolchain triggers newly published standard-library advisories. Bump only the preferred toolchain to Go 1.27.2; minimum Go 1.26.0 and dependencies stay unchanged.
Released Staticcheck v0.8.1 cannot decode Go 1.27.2 export data. Run that unchanged version on patched Go 1.26.9 with
GOTOOLCHAIN=local. Onlycheck_go127_test.goandsink_paths_go127_test.goare excluded from this lint pass; Go 1.27 tests/race/vet still cover them. No production source is excluded by this version selection, and security checks remain on the patched preferred toolchain.No new real-target cases or model semantics redesign.
The full-suite matrix and wholeprogram/CLI race explicitly pin the patched versions: floating setup-go aliases were observed resolving to older patches despite
check-latest. Test commands, assertions, and coverage are unchanged.