i18n(ja): fix dropped verb in release-5.4.0.md TiKV log parameter row - #23830
i18n(ja): fix dropped verb in release-5.4.0.md TiKV log parameter row#23830yahonda wants to merge 1 commit into
Conversation
The TiKV log-parameter renaming row was missing the predicate "are
replaced with" ("...に置き換えられます"), leaving the sentence as a
bare list of parameter names with no verb. Verified against the EN
source, which reads "The names of TiKV log parameters are replaced
with the names that are consistent with TiDB log parameters, which
are `log.level`, ...".
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review. 📝 WalkthroughWalkthroughThe TiDB 5.4 release notes now complete the TiKV log parameter replacement description. The documented compatibility behavior remains unchanged. ChangesRelease note correction
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This documentation-only correction is ready to merge. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
First-time contributors' checklist
What is changed, added or deleted? (Required)
The TiKV log-parameter renaming row in the compatibility-changes table was missing the predicate "are replaced with" (
〜に置き換えられます), leaving the sentence as a bare list of parameter names with no verb:Before:
TiKV ログ パラメータの名前は、TiDB ログ パラメータと互換性のある名前\log.level`、`log.format`、`log.file.filename`、および`log.enable-timestamp`。`Verified against the EN source, which reads: "The names of TiKV log parameters are replaced with the names that are consistent with TiDB log parameters, which are `log.level`, `log.format`, `log.file.filename`, and `log.enable-timestamp`."
Which TiDB version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?
AI agent involvement
Do your changes match any of the following descriptions?
Summary by CodeRabbit