Skip to content

i18n(ja): fix dropped verb in release-5.4.0.md TiKV log parameter row - #23830

Open
yahonda wants to merge 1 commit into
pingcap:i18n-ja-release-8.5from
yahonda:fix-release-5.4.0-dropped-verb
Open

i18n(ja): fix dropped verb in release-5.4.0.md TiKV log parameter row#23830
yahonda wants to merge 1 commit into
pingcap:i18n-ja-release-8.5from
yahonda:fix-release-5.4.0-dropped-verb

Conversation

@yahonda

@yahonda yahonda commented Sep 11, 2026

Copy link
Copy Markdown
Member

First-time contributors' checklist

What is changed, added or deleted? (Required)

The TiKV log-parameter renaming row in the compatibility-changes table was missing the predicate "are replaced with" (〜に置き換えられます), leaving the sentence as a bare list of parameter names with no verb:

Before: TiKV ログ パラメータの名前は、TiDB ログ パラメータと互換性のある名前\log.level`、`log.format`、`log.file.filename`、および`log.enable-timestamp`。`

Verified against the EN source, which reads: "The names of TiKV log parameters are replaced with the names that are consistent with TiDB log parameters, which are `log.level`, `log.format`, `log.file.filename`, and `log.enable-timestamp`."

Which TiDB version(s) do your changes apply to? (Required)

  • i18n-ja-release-8.5 (TiDB Japanese documentation for TiDB 8.5 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

AI agent involvement

  • The changes in this PR were primarily made by an AI agent on behalf of the PR author.

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

Summary by CodeRabbit

  • Documentation
    • Corrected the TiDB 5.4 configuration-parameter release note describing the replacement of legacy TiKV logging parameters with TiDB-compatible names.
    • Clarified that legacy parameters remain compatible when set to non-default values, while the newer parameters take precedence when both are configured.

The TiKV log-parameter renaming row was missing the predicate "are
replaced with" ("...に置き換えられます"), leaving the sentence as a
bare list of parameter names with no verb. Verified against the EN
source, which reads "The names of TiKV log parameters are replaced
with the names that are consistent with TiDB log parameters, which
are `log.level`, ...".

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@ti-chi-bot

ti-chi-bot Bot commented Sep 11, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kissmydb for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 11, 2026
@coderabbitai

coderabbitai Bot commented Sep 11, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: bc140623-cb77-4186-b646-1071419b06db

📥 Commits

Reviewing files that changed from the base of the PR and between 645c2ff and e25a4f7.

📒 Files selected for processing (1)
  • releases/release-5.4.0.md

Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review.


📝 Walkthrough

Walkthrough

The TiDB 5.4 release notes now complete the TiKV log parameter replacement description. The documented compatibility behavior remains unchanged.

Changes

Release note correction

Layer / File(s) Summary
Correct TiKV parameter description
releases/release-5.4.0.md
Completes the statement that the old TiKV log parameter names are replaced by the TiDB-compatible names. Existing compatibility semantics remain unchanged.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to e25a4

This documentation-only correction is ready to merge.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: fixing the missing verb in the Japanese TiKV log-parameter row.
Description check ✅ Passed The description explains the change, provides the before text and English reference, identifies the affected Japanese 8.5 documentation branch, and completes the relevant checklist sections. Optional …
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant