i18n(ja): restore literal English error messages in DM precheck troubleshooting - #23834
i18n(ja): restore literal English error messages in DM precheck troubleshooting#23834yahonda wants to merge 3 commits into
Conversation
…leshooting Seven heading-level error messages were quoted-string literals in the EN source (actual DM/TiDB Cloud error text a user would see verbatim on screen), but were translated into Japanese prose instead of kept as literal English. This defeats the doc's purpose as a troubleshooting reference organized by "find the exact message you saw" -- a reader can't match a Japanese paraphrase against the English text actually shown by the product. The file's other, non-quoted "Error message: ..." headings are plain descriptive section labels (not literal on-screen text) and were correctly left translated. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 4 included reviews per hour; 1 remains after this review. 📝 WalkthroughWalkthroughSeven troubleshooting headings now use the original English error messages. Anchor IDs remain unchanged. One TiKV storage sentence also has a minor Japanese wording change. ChangesDM troubleshooting documentation
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~3 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to This documentation update introduces no material merge risk. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@coderabbitai full review |
|
The previous commit wrapped the restored literal error text in Japanese corner brackets. This file already has an untouched sibling heading quoting literal error text with straight double quotes (matching the EN source's own quote style), so switch to that for consistency within the same file instead of introducing a second bracket convention. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
@coderabbitai full review |
✅ Action performedFull review finished. |
The link text used the dictionary form "増やす" directly before "から", which reads as an odd, disconnected clause instead of the intended "after increasing X, then do Y" sequence the EN source describes. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
First-time contributors' checklist
What is changed, added or deleted? (Required)
Seven heading-level error messages in this troubleshooting doc are quoted-string literals in the EN source (actual DM/TiDB Cloud error text a user would see verbatim on screen), but were translated into Japanese prose instead of kept as literal English. This defeats the doc's purpose as a troubleshooting reference organized by "find the exact message you saw" — a reader can't match a Japanese paraphrase against the English text actually shown by the product.
The file's other, non-quoted "Error message: ..." headings are plain descriptive section labels (not literal on-screen text) and were correctly left translated — only the 7 quoted ones needed restoring.
Which TiDB version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?
AI agent involvement
Do your changes match any of the following descriptions?
Summary by CodeRabbit