Skip to content

i18n(ja): restore literal English error messages in DM precheck troubleshooting - #23834

Open
yahonda wants to merge 3 commits into
pingcap:i18n-ja-release-8.5from
yahonda:fix-dm-precheck-literal-error-messages
Open

i18n(ja): restore literal English error messages in DM precheck troubleshooting#23834
yahonda wants to merge 3 commits into
pingcap:i18n-ja-release-8.5from
yahonda:fix-dm-precheck-literal-error-messages

Conversation

@yahonda

@yahonda yahonda commented Sep 11, 2026

Copy link
Copy Markdown
Member

First-time contributors' checklist

What is changed, added or deleted? (Required)

Seven heading-level error messages in this troubleshooting doc are quoted-string literals in the EN source (actual DM/TiDB Cloud error text a user would see verbatim on screen), but were translated into Japanese prose instead of kept as literal English. This defeats the doc's purpose as a troubleshooting reference organized by "find the exact message you saw" — a reader can't match a Japanese paraphrase against the English text actually shown by the product.

The file's other, non-quoted "Error message: ..." headings are plain descriptive section labels (not literal on-screen text) and were correctly left translated — only the 7 quoted ones needed restoring.

Which TiDB version(s) do your changes apply to? (Required)

  • i18n-ja-release-8.5 (TiDB Japanese documentation for TiDB 8.5 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

AI agent involvement

  • The changes in this PR were primarily made by an AI agent on behalf of the PR author.

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

Summary by CodeRabbit

  • Documentation
    • Updated seven migration error section headings to display the original English error messages.
    • Preserved existing section links and explanatory content.
    • Refined wording in the TiDB cluster storage guidance.

…leshooting

Seven heading-level error messages were quoted-string literals in
the EN source (actual DM/TiDB Cloud error text a user would see
verbatim on screen), but were translated into Japanese prose instead
of kept as literal English. This defeats the doc's purpose as a
troubleshooting reference organized by "find the exact message you
saw" -- a reader can't match a Japanese paraphrase against the
English text actually shown by the product.

The file's other, non-quoted "Error message: ..." headings are
plain descriptive section labels (not literal on-screen text) and
were correctly left translated.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Sep 11, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 6dd8285b-7ae8-4a75-a9cd-1c07815d011c

📥 Commits

Reviewing files that changed from the base of the PR and between 3425c1f and e9a0f9f.

📒 Files selected for processing (1)
  • tidb-cloud/tidb-cloud-dm-precheck-and-troubleshooting.md

Included review availability: Your plan provides up to 4 included reviews per hour; 1 remains after this review.


📝 Walkthrough

Walkthrough

Seven troubleshooting headings now use the original English error messages. Anchor IDs remain unchanged. One TiKV storage sentence also has a minor Japanese wording change.

Changes

DM troubleshooting documentation

Layer / File(s) Summary
Update troubleshooting error headings
tidb-cloud/tidb-cloud-dm-precheck-and-troubleshooting.md
Seven headings under “移行エラーとその解決策” now use the original English error messages. Their anchor IDs and section bodies remain unchanged, except for one TiKV storage sentence that changes “増やす” to “増やして”.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to e9a0f

This documentation update introduces no material merge risk.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: restoring literal English DM precheck error messages in the Japanese troubleshooting documentation.
Description check ✅ Passed The description explains the change, scope, affected documentation version, AI involvement, and applicable change categories. It is sufficiently complete, although the first-time contributor checklist…
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ti-chi-bot

ti-chi-bot Bot commented Sep 11, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign oreoxmt for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 11, 2026
@yahonda

yahonda commented Sep 11, 2026

Copy link
Copy Markdown
Member Author

@coderabbitai full review

@coderabbitai

coderabbitai Bot commented Sep 11, 2026

Copy link
Copy Markdown
⚠️ Action not completed

Review rate limited.


Your included review limit is currently reached under our Fair Usage Limits Policy. This review may still proceed through usage-based billing if eligible. Your next included review will be available in 13 minutes.

The previous commit wrapped the restored literal error text in
Japanese corner brackets. This file already has an untouched sibling
heading quoting literal error text with straight double quotes
(matching the EN source's own quote style), so switch to that for
consistency within the same file instead of introducing a second
bracket convention.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@yahonda

yahonda commented Sep 11, 2026

Copy link
Copy Markdown
Member Author

@coderabbitai full review

@coderabbitai

coderabbitai Bot commented Sep 11, 2026

Copy link
Copy Markdown
✅ Action performed

Full review finished.

The link text used the dictionary form "増やす" directly before "から",
which reads as an odd, disconnected clause instead of the intended
"after increasing X, then do Y" sequence the EN source describes.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant